Stabilize PeriodicMetricReaderBuilder#setMaxExportBatchSize - #8829
Conversation
|
68f3b72 to
fd74395
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8829 +/- ##
============================================
- Coverage 91.44% 91.43% -0.01%
+ Complexity 10667 10666 -1
============================================
Files 1007 1007
Lines 28686 28678 -8
Branches 3676 3676
============================================
- Hits 26232 26223 -9
+ Misses 1657 1656 -1
- Partials 797 799 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
f7b54a6 to
192197d
Compare
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Stabilizes PeriodicMetricReaderBuilder#setMaxExportBatchSize(int) as public API and removes the reflective workaround.
Changes:
- Exposes the batch-size setter publicly.
- Updates declarative configuration and tests.
- Removes the obsolete helper and records the API diff.
File summaries
| File | Description |
|---|---|
sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/internal/SdkMeterProviderUtil.java |
Removes the reflective helper. |
sdk/metrics/src/main/java/io/opentelemetry/sdk/metrics/export/PeriodicMetricReaderBuilder.java |
Exposes the batch-size setter publicly. |
sdk-extensions/declarative-config/src/test/java/io/opentelemetry/sdk/autoconfigure/declarativeconfig/MetricReaderFactoryTest.java |
Updates expected builder usage. |
sdk-extensions/declarative-config/src/main/java/io/opentelemetry/sdk/autoconfigure/declarativeconfig/MetricReaderFactory.java |
Calls the public setter directly. |
docs/apidiffs/current_vs_latest/opentelemetry-sdk-metrics.txt |
Records the API visibility change. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
192197d to
9f4d6ad
Compare
Pull request dashboard statusMerged · refreshed 2026-09-25 18:42 UTC Status above doesn't look right?
|
9f4d6ad to
246bd89
Compare
Stabilizes
PeriodicMetricReaderBuilder#setMaxExportBatchSize(int)following its stabilization in the OpenTelemetry Specification (open-telemetry/opentelemetry-specification#5291).Changes
PeriodicMetricReaderBuilder#setMaxExportBatchSize(int)public(@since 1.67.0).SdkMeterProviderUtil#setMaxExportBatchSize.MetricReaderFactoryto callbuilder.setMaxExportBatchSize(...)directly.