Skip to content

Set original_payload_format to "jfr" in the JFR export example - #8809

Merged
jack-berg merged 1 commit into
open-telemetry:mainfrom
thswlsqls:fix/jfr-example-original-payload-format
Sep 14, 2026
Merged

jack-berg merged 1 commit into
open-telemetry:mainfrom
thswlsqls:fix/jfr-example-original-payload-format

Conversation

@thswlsqls

Copy link
Copy Markdown
Contributor

Fixes #8807

Description

  • JfrExportExample.convertJfrFile() attaches the raw .jfr file bytes as originalPayload but passes the literal "format" as originalPayloadFormat; this changes it to "jfr".
  • The ProfileData.getOriginalPayloadFormat() Javadoc requires the field when original_payload is present and defers to semantic conventions for its values; the profiles.proto comment on original_payload_format gives jfr as its example, and the specification profiles README lists pprof, jfr and linux_perf as known values.
  • "format" is the placeholder from the exporter test fixture FakeTelemetryUtil, unchanged since the module was added in profiles: split out SDK and JFR shim modules #8207.
  • Related: profiles: improve JFR export example and align LinkData null-element with spec #8349 replaced the ValueTypeData.create(0, 0) placeholder in the same call but left this argument.

Testing done

@codecov

codecov Bot commented Sep 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.27%. Comparing base (77b1ac4) to head (f78176e).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #8809      +/-   ##
============================================
- Coverage     91.28%   91.27%   -0.02%     
+ Complexity    10528    10526       -2     
============================================
  Files          1008     1008              
  Lines         28465    28465              
  Branches       3617     3617              
============================================
- Hits          25984    25981       -3     
  Misses         1685     1685              
- Partials        796      799       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@opentelemetry-pr-dashboard

opentelemetry-pr-dashboard Bot commented Sep 12, 2026 •

Copy link
Copy Markdown

Pull request dashboard status

Merged · refreshed 2026-09-14 18:21 UTC

Status above doesn't look right?
  • Anything look wrong? Report it with what you expected; it helps us improve the dashboard.

@thswlsqls
thswlsqls marked this pull request as ready for review September 12, 2026 12:35
@thswlsqls
thswlsqls requested a review from a team as a code owner September 12, 2026 12:35

@jack-berg jack-berg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jack-berg
jack-berg merged commit a4c4400 into open-telemetry:main Sep 14, 2026
35 checks passed
@otelbot

otelbot Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution @thswlsqls! 🎉 We would like to hear from you about your experience contributing to OpenTelemetry by taking a few minutes to fill out this survey.

@thswlsqls
thswlsqls deleted the fix/jfr-example-original-payload-format branch September 17, 2026 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JFR export example sets original_payload_format to "format" instead of "jfr"

2 participants