Skip to content

Remove deprecated metrics APIs - #3990

Merged
anuraaga merged 1 commit into
open-telemetry:mainfrom
anuraaga:remove-deprecated-metrics-api
Dec 15, 2021
Merged

anuraaga merged 1 commit into
open-telemetry:mainfrom
anuraaga:remove-deprecated-metrics-api

Conversation

@anuraaga

Copy link
Copy Markdown
Contributor

No description provided.

@@ -1,188 +1,2 @@
Comparing source compatibility of against
+++ NEW CLASS: PUBLIC(+) STATIC(+) io.opentelemetry.api.metrics.DefaultMeter$NoopDoubleHistogram (not serializable)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah while I didn't think we should add a 1.9 vs 1.10-RC1 japi during the release, it looks like I should have at least refreshed current_vs_latest during the release, this is the diff vs RC1 (no diff)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should also just generate the api diffs between 0.9.0 and the RC, for completeness. We can end up also having 0.9.0->0.10.0 when we release for real.

@codecov

codecov Bot commented Dec 14, 2021

Copy link
Copy Markdown

Codecov Report

Merging #3990 (4775f58) into main (cbecf1f) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #3990      +/-   ##
============================================
+ Coverage     89.71%   89.76%   +0.04%     
+ Complexity     4272     4269       -3     
============================================
  Files           513      512       -1     
  Lines         12941    12934       -7     
  Branches       1248     1248              
============================================
  Hits          11610    11610              
+ Misses          927      922       -5     
+ Partials        404      402       -2     
Impacted Files Coverage Δ
...telemetry/sdk/metrics/SdkMeterProviderBuilder.java 96.29% <ø> (-0.38%) ⬇️
...toconfigure/OpenTelemetrySdkAutoConfiguration.java 61.90% <100.00%> (ø)
...etry/exporter/otlp/internal/CodedOutputStream.java 67.45% <0.00%> (-1.19%) ⬇️
...ntelemetry/sdk/extension/resources/OsResource.java 90.69% <0.00%> (+4.65%) ⬆️
...ava/io/opentelemetry/sdk/internal/RateLimiter.java 100.00% <0.00%> (+5.88%) ⬆️
...metry/sdk/extension/resources/ProcessResource.java 87.50% <0.00%> (+6.25%) ⬆️
...elemetry/sdk/extension/resources/HostResource.java 92.30% <0.00%> (+15.38%) ⬆️
...dk/extension/resources/ProcessRuntimeResource.java 100.00% <0.00%> (+16.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbecf1f...4775f58. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants