Links based sampler - #813
Merged
Merged
Conversation
jack-berg
reviewed
Apr 6, 2023
jack-berg
reviewed
Apr 6, 2023
jack-berg
reviewed
Apr 26, 2023
jack-berg
reviewed
Apr 26, 2023
jack-berg
reviewed
Apr 26, 2023
jack-berg
left a comment
jack-berg
left a comment
Member
There was a problem hiding this comment.
Sorry for the delay. Couple minor comments but looks good.
jack-berg
approved these changes
Apr 27, 2023
trask
approved these changes
Apr 28, 2023
Comment on lines
+24
to
+25
| private static final SamplingResult POSITIVE_SAMPLING_RESULT = SamplingResult.recordAndSample(); | ||
| private static final SamplingResult NEGATIVE_SAMPLING_RESULT = SamplingResult.drop(); |
Member
There was a problem hiding this comment.
I don't think these constants help improve readability or performance here, so I'd suggest inlining
Member
There was a problem hiding this comment.
@atshaw43 just checking in to make sure you saw this comment, thx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Feature addition
Problem
What if we only want to sample if and only if one of the span links is sampled.
Solution
Add a LinksBasedSampler sampler that samples if and only if a span link is sampled.
Testing:
Unit Tests