Webapp service name detector - #562
Merged
trask merged 17 commits intoNov 9, 2022
Merged
Conversation
breedx-splk
marked this pull request as ready for review
November 1, 2022 22:56
…iders/AppServerServiceNameProvider.java Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
…iders/AppServerServiceNameProvider.java Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
mateuszrzeszutek
approved these changes
Nov 4, 2022
trask
reviewed
Nov 9, 2022
| * SPDX-License-Identifier: Apache-2.0 | ||
| */ | ||
|
|
||
| package io.opentelemetry.resourceproviders; |
Member
There was a problem hiding this comment.
can all of these classes go under an internal package, or do users need access to them?
Contributor
Author
There was a problem hiding this comment.
So the AppServerServiceNameProvider will be the only real user-facing class (although the delegates could be too I suppose, if someone wanted to pull in only a subset of the supported app servers). For now, I think I should make the two interfaces package-private and that should help, right?
trask
approved these changes
Nov 9, 2022
trask
left a comment
trask
left a comment
Member
There was a problem hiding this comment.
For now, I think I should make the two interfaces package-private and that should help, right?
looks good, we can revisit visibility issues later too, thx
trask
pushed a commit
that referenced
this pull request
Nov 15, 2022
This is a continuation of #562 that introduces the first of several web app servers for which we will detect the service name. Because this is the first (GlassFish), it includes some of the helper/plumbing utilities. Subsequent additions will mostly be the `AppServer` implementations (and adding them to the delegate list).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the start of a few contributions of
ResourceDetectorimplementations from the Splunk distro. The first one coming up here is theAppServerServiceNameProvider. This will eventually detect when theservice.nameresource attribute is missing (and alsootel.service.namenot set in config) and will apply a series of heuristics for common application servers.Because the current implementation is not exactly small, it's being contributed piecemeal to make reviews easier. The implementation here doesn't actually apply any of the heuristics yet....to see what they'll look like when done, you can look in the splunk distribution impl.