firmware upload: add analysis configuration selection #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the new API, analysis configuration can be selected for a firmware. There should always be an analysis configuration called `Default`. This patch extends the `upload-firmware` CLI with analysis configuration selection by name. Not providing the name using the new `--analysis-configuration` option will result using the `Default` configuration, much like during Product Group selection.
martonilles
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the new API, analysis configuration can be selected for a firmware. There should always be an analysis configuration called
Default.This patch extends the
upload-firmwareCLI with analysis configuration selection by name. Not providing the name using the new--analysis-configurationoption will result using theDefaultconfiguration, much like during Product Group selection.