doc: update module.builtinModules sentence#57089
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Feb 16, 2025
Merged
doc: update module.builtinModules sentence#57089nodejs-github-bot merged 1 commit intonodejs:mainfrom
module.builtinModules sentence#57089nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
updates the sentence saying that `module.builtinModule` only contains the modules that can be loaded without `node:` (since v23.5.0 also prefix-only modules are included in the list)
Collaborator
|
Review requested:
|
nodejs-github-bot
added
doc
aduh95
approved these changes
Feb 16, 2025
aduh95
added
the
baking-for-lts
jasnell
approved these changes
Feb 16, 2025
ljharb
approved these changes
Feb 16, 2025
Contributor
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
cjihrig
approved these changes
Feb 16, 2025
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in f1b951f |
targos
pushed a commit
that referenced
this pull request
Feb 17, 2025
updates the sentence saying that `module.builtinModule` only contains the modules that can be loaded without `node:` (since v23.5.0 also prefix-only modules are included in the list) PR-URL: #57089 Refs: #56185 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
6 tasks
acidiney
pushed a commit
to acidiney/node
that referenced
this pull request
Feb 23, 2025
updates the sentence saying that `module.builtinModule` only contains the modules that can be loaded without `node:` (since v23.5.0 also prefix-only modules are included in the list) PR-URL: nodejs#57089 Refs: nodejs#56185 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95
added
dont-land-on-v20.x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
updates the sentence saying that
module.builtinModuleonly contains the modules that can be loaded withoutnode:(since v23.5.0 also prefix-only modules are included in the list)Refs: #56185