fs: fix fs.promises.mkdir to also report ENOSPC correctly#56918
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Jun 16, 2025
jackyzha0:jackyzha0/enoent-mkdir-async
Merged
fs: fix fs.promises.mkdir to also report ENOSPC correctly#56918nodejs-github-bot merged 1 commit intonodejs:mainfrom jackyzha0:jackyzha0/enoent-mkdir-async
nodejs-github-bot merged 1 commit intonodejs:mainfrom
jackyzha0:jackyzha0/enoent-mkdir-async
Conversation
nodejs-github-bot
added
c++
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56918 +/- ##
==========================================
- Coverage 89.18% 89.16% -0.03%
==========================================
Files 665 665
Lines 192543 192574 +31
Branches 37045 37085 +40
==========================================
- Hits 171726 171702 -24
- Misses 13636 13658 +22
- Partials 7181 7214 +33
🚀 New features to boost your workflow:
|
github-actions
bot
removed
the
request-ci
Collaborator
Contributor
Author
|
looks like two test failures for the test runner itself, i think its unrelated to the changeset, are those two known to flake? |
addaleax
approved these changes
Feb 11, 2025
Contributor
Author
Collaborator
Contributor
Author
|
hey! sorry to bump on this again, was also curious about the process of backporting fixes like these to previous Node.js releases (we are currently on v20.9 but can also upgrade to LTS) |
Contributor
Author
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 908f9f1 |
Member
|
Sorry for the long delay @jackyzha0 😞 |
Contributor
Author
|
its ok, just happy it got in and thanks for the review :) |
RafaelGSS
pushed a commit
that referenced
this pull request
Jun 23, 2025
PR-URL: #56918 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Jun 23, 2025
aduh95
pushed a commit
that referenced
this pull request
Jul 21, 2025
PR-URL: #56918 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
aduh95
pushed a commit
that referenced
this pull request
Jul 24, 2025
PR-URL: #56918 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuation of #42811 which fixes #42808 for the async case
Happy to try to write a test but left as is for now seeing as the previous PR also didn't: #42811 (review)