Skip to content

deps: update undici to 6.15.0#52763

Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom
KhafraDev:update-undici
May 2, 2024
Merged

deps: update undici to 6.15.0#52763
nodejs-github-bot merged 2 commits intonodejs:mainfrom
KhafraDev:update-undici

Conversation

@KhafraDev
Copy link
Member

@KhafraDev KhafraDev commented Apr 30, 2024

Updates undici to v6.15.0 by running tools/dep_updaters/update-undici.sh and fixes test failures.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 30, 2024

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. needs-ci PRs that need a full CI run. labels Apr 30, 2024
@KhafraDev KhafraDev mentioned this pull request Apr 30, 2024
Closed
mcollina
mcollina approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina
Copy link
Member

mcollina commented Apr 30, 2024

linter is failing

@KhafraDev
Copy link
Member Author

KhafraDev commented Apr 30, 2024

the tests should also pass once undici is updated again since the error messages were slightly improved

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2024
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels May 1, 2024
@github-actions
Copy link
Contributor

github-actions bot commented May 1, 2024

Failed to start CI
   ⚠  Something was pushed to the Pull Request branch since the last approving review.
   ✘  Refusing to run CI on potentially unsafe PR
https://github.com/nodejs/node/actions/runs/8907550593

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 1, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 1, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58831/

mcollina
mcollina approved these changes May 1, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina mentioned this pull request May 1, 2024
Merged
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 1, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58834/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 1, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58838/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 2, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/58851/

@mcollina mcollina added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels May 2, 2024
@panva panva added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label May 2, 2024
@mcollina
Copy link
Member

mcollina commented May 2, 2024

This needs to wait 9 more hours to land

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 2, 2024
@nodejs-github-bot nodejs-github-bot merged commit ae8a5ff into nodejs:main May 2, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 2, 2024

Landed in ae8a5ff

Whitecx pushed a commit to Whitecx/node that referenced this pull request May 2, 2024
@KhafraDev @Whitecx
deps: update undici to 6.15.0
87b896b 
PR-URL: nodejs#52763
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Ch3nYuY pushed a commit to Ch3nYuY/node that referenced this pull request May 8, 2024
@KhafraDev
deps: update undici to 6.15.0
7dc4ab4 
PR-URL: nodejs#52763
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@KhafraDev KhafraDev deleted the update-undici branch May 15, 2024 15:38
@KhafraDev KhafraDev mentioned this pull request May 15, 2024
Closed
targos pushed a commit that referenced this pull request Jun 1, 2024
@KhafraDev @targos
deps: update undici to 6.15.0
96f72ae 
PR-URL: #52763
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jun 7, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@KhafraDev @marco-ippolito
deps: update undici to 6.15.0
e3b26b7 
PR-URL: #52763
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Jun 17, 2024
Merged
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@KhafraDev @marco-ippolito
deps: update undici to 6.15.0
e61a4a5 
PR-URL: #52763
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jun 17, 2024
@KhafraDev @marco-ippolito
deps: update undici to 6.15.0
f0a33f9 
PR-URL: #52763
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@KhafraDev @eliphazbouye
deps: update undici to 6.15.0
5ef0213 
PR-URL: nodejs#52763
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@KhafraDev @bmeck
deps: update undici to 6.15.0
48cf618 
PR-URL: nodejs#52763
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@KhafraDev @marco-ippolito
deps: update undici to 6.15.0
0c41e08 
PR-URL: #52763
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@KhafraDev @marco-ippolito
deps: update undici to 6.15.0
b32b62d 
PR-URL: #52763
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mcollina mcollina mcollina approved these changes

@panva panva panva approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@trivikr trivikr trivikr approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dependencies Pull requests that update a dependency file.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@KhafraDev @nodejs-github-bot @mcollina @panva @UlisesGascon @trivikr @marco-ippolito