test: fix broken env fuzzer by initializing process #51080
test: fix broken env fuzzer by initializing process #51080aduh95 merged 1 commit intonodejs:mainfrom
Conversation
105a7cf to
5f55806
Compare
joyeecheung
left a comment
There was a problem hiding this comment.
LGTM though I do wonder why this is not using node::InitializeOncePerProcess() instead..
Actually I just noticed that it seems the fuzzers aren't tearing down the platform etc. properly. See node/test/cctest/node_test_fixture.cc Lines 36 to 43 in b68fa59 |
Thank you for the feedback. I will test this and make a follow-up PR. |
Signed-off-by: Adam Korczynski <adam@adalogics.com>
|
Landed in d9b61db |
Signed-off-by: Adam Korczynski <adam@adalogics.com> PR-URL: #51080 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Signed-off-by: Adam Korczynski <adam@adalogics.com> PR-URL: #51080 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Signed-off-by: Adam Korczynski <adam@adalogics.com> PR-URL: #51080 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Signed-off-by: Adam Korczynski <adam@adalogics.com> PR-URL: #51080 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Signed-off-by: Adam Korczynski <adam@adalogics.com> PR-URL: nodejs#51080 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Signed-off-by: Adam Korczynski <adam@adalogics.com> PR-URL: nodejs#51080 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Fixes a broken fuzzer.
It looks like the fuzzer is leaking memory, but it is so slow that it is hard to tell. Once the fuzzer starts running on OSS-Fuzz again, we should get good feedback. If it has a leak, then I plan to fix it over the next couple of weeks; If anyone can spot a possible leak without running it, it would be a great help.