fs: throw fchownSync error from c++#51075
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom Dec 12, 2023
Merged
Conversation
nodejs-github-bot
added
c++
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Member
Author
|
cc @nodejs/fs @nodejs/cpp-reviewers appreciate if you could leave a review. |
Qard
approved these changes
Dec 7, 2023
Member
|
I believe @H4ad suggested to re-run benchmarks for these changes in nodejs/performance#106. |
Member
|
@anonrig Can you update the benchmark of |
jasnell
approved these changes
Dec 9, 2023
Collaborator
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 3551dc0 |
Member
Author
I missed this comment. Sorry I just realized that I didn't comment on this. |
RafaelGSS
pushed a commit
that referenced
this pull request
Dec 15, 2023
PR-URL: #51075 Refs: nodejs/performance#106 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
richardlau
pushed a commit
that referenced
this pull request
Mar 25, 2024
PR-URL: #51075 Refs: nodejs/performance#106 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: nodejs/performance#106
#49920 seems to be abandoned.
cc @nodejs/fs