test_runner: add jsdocs to MockFunctionContext and MockTracker#49555
Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom Sep 14, 2023
Merged
test_runner: add jsdocs to MockFunctionContext and MockTracker#49555nodejs-github-bot merged 2 commits intonodejs:mainfrom
nodejs-github-bot merged 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
needs-ci
ocodista
changed the title
ErickWendel
requested changes
Sep 8, 2023
Member
|
@ocodista Also, don't forget to add jsdocs for constructors, getters, and setters and everything that would be accessible on the public API |
Contributor
Author
|
@ErickWendel Thank you for the notes and reviews, I applied all the naming suggestions and included jsdocs for the getter/setter and get times function. Please take a new look whenever you have some time. |
Member
|
Hey thanks for your contribution 🙇 please revert all the unrelated style changes and keep the JSDoc stuff? |
Contributor
Author
Thank you! Just did it 😁 |
ErickWendel
requested changes
Sep 12, 2023
ErickWendel
requested changes
Sep 12, 2023
github-actions
bot
removed
the
request-ci
Collaborator
atlowChemi
approved these changes
Sep 13, 2023
Member
atlowChemi
left a comment
atlowChemi
left a comment
There was a problem hiding this comment.
Overall LGTM, thanks for this contribution 🙂
Co-authored-by: Chemi Atlow <chemi@atlow.co.il>
atlowChemi
approved these changes
Sep 13, 2023
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
15 tasks
Contributor
Author
Thank you!!! |
atlowChemi
added
the
commit-queue
atlowChemi
added
the
commit-queue-squash
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 4efa374 |
This was referenced Sep 15, 2023
ruyadorno
pushed a commit
that referenced
this pull request
Sep 28, 2023
PR-URL: #49555 Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Nov 1, 2023
PR-URL: nodejs#49555 Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
targos
pushed a commit
that referenced
this pull request
Nov 27, 2023
PR-URL: #49555 Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49555 Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
sercher
added a commit
to sercher/graaljs
that referenced
this pull request
Apr 25, 2024
PR-URL: nodejs/node#49555 Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add JSDocs for all public functions of MockFunctionContext
cc @nodejs/test_runner