Conversation
Refs: v8/v8@10.2.154.23...10.2.154.26 PR-URL: #46446 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
PR-URL: #46353 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #46673 Reviewed-By: Luke Karrys <luke@lukekarrys.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ruy Adorno <ruyadorno@google.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
PR-URL: #46711 Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
nodejs-github-bot
added
dont-land-on-v14.x
fast-track
This comment was marked as outdated.
This comment was marked as outdated.
MylesBorins
added
request-ci
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
Contributor
|
The commit message of a1a9d91 says "PR-URL: TODO", this would need to be amended I think. |
24 tasks
MylesBorins
force-pushed
the
v18.14.2-proposal
branch
from
a1a9d91 to
4df0001
Compare
Collaborator
targos
approved these changes
Feb 20, 2023
ruyadorno
approved these changes
Feb 20, 2023
Contributor
Author
BethGriggs
approved these changes
Feb 20, 2023
26 tasks
Contributor
Author
|
Tests are all green and nothing looks odd in CITGM. I'll do one last review of CITGM tomorrow before promoting the release. |
VoltrexKeyva
added
release
Contributor
Author
|
There is a newish failure with I'm going to move forward with the release |
MylesBorins
added a commit
to nodejs/nodejs.org
that referenced
this pull request
Feb 21, 2023
Trott
pushed a commit
to nodejs/nodejs.org
that referenced
this pull request
Feb 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2023-02-21, Version 18.14.2 'Hydrogen' (LTS), @MylesBorins
Notable Changes
f864bef32a] - deps: upgrade npm to 9.5.0 (npm team) #46673Commits
880a65d7ff] - build: deletesnapshot.blobfile from the project (Juan José Arboleda) #46626cbea56efda] - deps: update undici to 5.20.0 (Node.js GitHub Bot) #46711f864bef32a] - deps: upgrade npm to 9.5.0 (npm team) #46673648041d568] - deps: upgrade npm to 9.4.0 (npm team) #463535e1f213f3c] - deps: patch V8 to 10.2.154.26 (Michaël Zasso) #46446