doc: improvements to domain.markdown copy#4451
doc: improvements to domain.markdown copy#4451jasnell wants to merge 2 commits intonodejs:masterfrom
Conversation
|
@nodejs/documentation @misterdjules |
doc/api/domain.markdown
Outdated
|
Some minor nits, but LGTM when those are addressed. |
General improvements to the domain.markdown copy including improved examples.
b85972d to
c2ca566
Compare
|
@Qard ... fixed! |
doc/api/domain.markdown
Outdated
There was a problem hiding this comment.
It might help to mention why the master process exits with an error in this case. Unless readers are familiar with the cluster module, it's not crystal clear.
|
@jasnell Thank you for doing that! I'm not a fan of having the first/only examples tied to using the Once the rest of my comments are addressed I'll take another look, but this already looks like a great improvement. |
|
@misterdjules .. thanks for the comments! I'll update shortly |
7da4fd4 to
c7066fb
Compare
General improvements to the domain.markdown copy including
improved examples.