esm: fix chain advances when loader calls `next<HookName>` multiple times by JakobJingleheimer · Pull Request #43303 · nodejs/node

JakobJingleheimer · 2022-06-02T21:40:58Z

fixes #43238

nodejs-github-bot · 2022-06-02T21:41:02Z

Review requested:

@nodejs/loaders
@nodejs/modules

lib/internal/modules/esm/loader.js

test/es-module/test-esm-loader-chaining.mjs

lib/internal/modules/esm/loader.js

JakobJingleheimer · 2022-06-05T07:29:20Z

@tniessen is the current test failure something I can ignore? I can’t see how it’s related (and it affects only 1 system). Rich and I both tried re-triggering it, but it timed out again both times.

GitHub Actions
/ test-asan
test/parallel/test-cluster-primary-kill.js#L1
Command: out/Release/node /home/runner/work/node/node/test/parallel/test-cluster-primary-kill.js
--- TIMEOUT ---

https://github.com/nodejs/node/pull/43303/files#diff-08e6bc52a7fd6d16a58fc1a7fea64758fcf0481cc4ecff14618824c0239814fa

nodejs-github-bot · 2022-06-05T08:48:00Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44361/

nodejs-github-bot · 2022-06-05T10:28:13Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44362/

nodejs-github-bot · 2022-06-05T12:20:31Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44363/

tniessen · 2022-06-05T12:20:46Z

@JakobJingleheimer No, sorry. As long as nobody fixes the underlying issue, we'll have to keep retrying.

JakobJingleheimer · 2022-06-05T12:30:20Z

Sorry, are you saying it's signalling a legit problem in the PR or there is a problem in the test?

If the former, do we have any idea where/why the test has a problem? (Is it tracked? I might try to fix it)

If the latter, can I just add the label and otherwise ignore it?

nodejs-github-bot · 2022-06-05T14:05:01Z

CI: https://ci.nodejs.org/job/node-test-pull-request/44365/

Trott · 2022-06-05T14:15:56Z

Looks like it passed on the 4th run.

If the latter, can I just add the label and otherwise ignore it?

The commit queue won't land something if a GitHub Action failed.

aduh95 · 2022-06-05T14:16:35Z

If the latter, can I just add the label and otherwise ignore it?

What label? In order for a PR to land, all the GitHub Actions CIs must be green, and depending if the PR content affects the node binary, a passing Jenkins CI. The CQ won't land a PR if it doesn't meet this requirement.
If by "ignoring it", you mean re-spawn the test-asan job until it ends up green, then sure you can do that (btw it's green now).

The ASan CI has been very flaky lately (https://github.com/nodejs/node/issues?q=is%3Aissue+asan+is%3Aopen+label%3Aflaky-test), which is a pain but as Tobias said, it's something we have to suffer until someone addresses the underlying issue(s).

JakobJingleheimer · 2022-06-05T14:31:56Z

Oh, I was thinking commit-queue-failed, which isn't right.

Ah, cool; I'll wait for the remaining actions to finish. Thanks!

nodejs-github-bot · 2022-06-05T17:33:48Z

Landed in 765666a

JakobJingleheimer · 2022-06-05T18:15:04Z

Backport blocked by #42623 (which is itself blocked for backport)

PR-URL: nodejs#43303 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: #43303 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

PR-URL: nodejs/node#43303 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

JakobJingleheimer added esm Issues and PRs related to the ECMAScript Modules implementation. loaders Issues and PRs related to ES module loaders labels Jun 2, 2022

JakobJingleheimer requested review from GeoffreyBooth and guybedford June 2, 2022 21:40

nodejs-github-bot added errors Issues and PRs related to JavaScript errors originated in Node.js core. needs-ci PRs that need a full CI run. labels Jun 2, 2022

JakobJingleheimer commented Jun 2, 2022

View reviewed changes

lib/internal/modules/esm/loader.js Outdated Show resolved Hide resolved

This comment was marked as resolved.

Sign in to view

JakobJingleheimer force-pushed the esm/fix-multiple-next-calls-advancing-chain branch from 3cf8f28 to 9099755 Compare June 2, 2022 22:01

GeoffreyBooth reviewed Jun 2, 2022

View reviewed changes

lib/internal/modules/esm/loader.js Show resolved Hide resolved

lib/internal/modules/esm/loader.js Outdated Show resolved Hide resolved

lib/internal/modules/esm/loader.js Show resolved Hide resolved

lib/internal/modules/esm/loader.js Outdated Show resolved Hide resolved

aduh95 reviewed Jun 2, 2022

View reviewed changes

lib/internal/modules/esm/loader.js Outdated Show resolved Hide resolved

aduh95 reviewed Jun 2, 2022

View reviewed changes

lib/internal/modules/esm/loader.js Outdated Show resolved Hide resolved

aduh95 reviewed Jun 2, 2022

View reviewed changes

test/es-module/test-esm-loader-chaining.mjs Outdated Show resolved Hide resolved

aduh95 reviewed Jun 3, 2022

View reviewed changes

lib/internal/modules/esm/loader.js Outdated Show resolved Hide resolved

lib/internal/modules/esm/loader.js Outdated Show resolved Hide resolved

GeoffreyBooth reviewed Jun 3, 2022

View reviewed changes

lib/internal/modules/esm/loader.js Outdated Show resolved Hide resolved

lib/internal/modules/esm/loader.js Show resolved Hide resolved

lib/internal/modules/esm/loader.js Show resolved Hide resolved

esm: fix chain advances when loader calls next<HookName> multiple times

4a2969b

JakobJingleheimer force-pushed the esm/fix-multiple-next-calls-advancing-chain branch from 910d4ff to 4a2969b Compare June 4, 2022 09:23

JakobJingleheimer added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 4, 2022

fixup: add return value to JSDoc for nextHookFactory's validate

306429c

GeoffreyBooth approved these changes Jun 4, 2022

View reviewed changes

ljharb reviewed Jun 4, 2022

View reviewed changes

lib/internal/modules/esm/loader.js Show resolved Hide resolved

lib/internal/modules/esm/loader.js Show resolved Hide resolved

JakobJingleheimer added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2022

aduh95 approved these changes Jun 5, 2022

View reviewed changes

JakobJingleheimer added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 5, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 5, 2022

nodejs-github-bot merged commit 765666a into nodejs:master Jun 5, 2022

JakobJingleheimer added the backport-blocked-v18.x label Jun 5, 2022

danielleadams pushed a commit that referenced this pull request Jun 11, 2022

esm: fix chain advances when loader calls next<HookName> multiple times

601d933

PR-URL: #43303 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

danielleadams mentioned this pull request Jun 11, 2022

v18.4.0 proposal #43385

Merged

JakobJingleheimer mentioned this pull request Jun 15, 2022

esm: convert resolve hook to synchronous #43363

Merged

JakobJingleheimer removed the backport-blocked-v18.x label Jun 18, 2022

targos pushed a commit that referenced this pull request Jul 12, 2022

esm: fix chain advances when loader calls next<HookName> multiple times

10bcad5

PR-URL: #43303 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos mentioned this pull request Jul 12, 2022

v18.6.0 release proposal #43789

Merged

targos pushed a commit that referenced this pull request Jul 19, 2022

esm: fix chain advances when loader calls next<HookName> multiple times

4c726b0

PR-URL: #43303 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos pushed a commit that referenced this pull request Jul 31, 2022

esm: fix chain advances when loader calls next<HookName> multiple times

df3f5cb

PR-URL: #43303 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

targos mentioned this pull request Aug 3, 2022

v16.17.0 release proposal #44098

Merged

Changqing-JING mentioned this pull request Jun 9, 2023

src: handle wasm out of bound in osx will raise SIGBUS correctly #46561

Merged

JakobJingleheimer mentioned this pull request Jul 11, 2023

esm: unflag Module.register and allow nested loader import() #48559

Merged

Uh oh!

Conversation

JakobJingleheimer commented Jun 2, 2022

Uh oh!

nodejs-github-bot commented Jun 2, 2022 • edited by JakobJingleheimer Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JakobJingleheimer commented Jun 5, 2022

Uh oh!

nodejs-github-bot commented Jun 5, 2022

Uh oh!

nodejs-github-bot commented Jun 5, 2022

Uh oh!

nodejs-github-bot commented Jun 5, 2022

Uh oh!

tniessen commented Jun 5, 2022

Uh oh!

JakobJingleheimer commented Jun 5, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jun 5, 2022

Uh oh!

Trott commented Jun 5, 2022

Uh oh!

aduh95 commented Jun 5, 2022

Uh oh!

JakobJingleheimer commented Jun 5, 2022

Uh oh!

nodejs-github-bot commented Jun 5, 2022

Uh oh!

JakobJingleheimer commented Jun 5, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

nodejs-github-bot commented Jun 2, 2022 •

edited by JakobJingleheimer

Loading

JakobJingleheimer commented Jun 5, 2022 •

edited

Loading