meta: update .mailmap for recent README name change by Trott · Pull Request #43027 · nodejs/node

Trott · 2022-05-09T21:00:27Z

No description provided.

github-actions · 2022-05-09T21:01:01Z

Fast-track has been requested by @Trott. Please 👍 to approve.

Trott · 2022-05-09T21:02:05Z

AUTHORS

 Sergey Nazaryev <sergey@nazaryev.com>
 William Marlow <william.marlow@ibm.com>
 Keyhan Vakil <60900335+airtable-keyhanvakil@users.noreply.github.com>
+Feng Yu <F3n67u@outlook.com>


This line is a side-effect of running tools/update-authors.js after updating .mailmap. I think it's fine to leave it, rather than removing it only so that the scheduled job re-adds it in a few days.

Trott · 2022-05-09T21:02:39Z

Without this change, it's possible that tools/find-inactive-collaborators.js will incorrectly flag the user as inactive.

Trott · 2022-05-09T23:06:29Z

Removed commit-queue label because this needs one more fast-track approval. Feel free to add it back if/when this gets that second approval.

nodejs-github-bot · 2022-05-10T05:56:18Z

Commit Queue failed

- Loading data for nodejs/node/pull/43027
✔  Done loading data for nodejs/node/pull/43027
----------------------------------- PR info ------------------------------------
Title      meta: update .mailmap for recent README name change (#43027)
Author     Rich Trott  (@Trott)
Branch     Trott:update -> nodejs:master
Labels     fast-track, author ready
Commits    1
 - meta: update .mailmap for recent README name change
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/43027
Reviewed-By: Zeyu "Alex" Yang 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43027
Reviewed-By: Zeyu "Alex" Yang 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 09 May 2022 21:00:27 GMT
   ✔  Approvals: 3
   ✔  - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/43027#pullrequestreview-966828530
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43027#pullrequestreview-966884084
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43027#pullrequestreview-967180646
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least two collaborators' approvals (👍).
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/2298687477

nodejs-github-bot · 2022-05-10T15:38:31Z

Commit Queue failed

- Loading data for nodejs/node/pull/43027
✔  Done loading data for nodejs/node/pull/43027
----------------------------------- PR info ------------------------------------
Title      meta: update .mailmap for recent README name change (#43027)
Author     Rich Trott  (@Trott)
Branch     Trott:update -> nodejs:master
Labels     fast-track, author ready
Commits    1
 - meta: update .mailmap for recent README name change
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/43027
Reviewed-By: Zeyu "Alex" Yang 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/43027
Reviewed-By: Zeyu "Alex" Yang 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 09 May 2022 21:00:27 GMT
   ✔  Approvals: 3
   ✔  - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/43027#pullrequestreview-966828530
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/43027#pullrequestreview-966884084
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/43027#pullrequestreview-967180646
   ℹ  This PR is being fast-tracked
   ✖  The fast-track request requires at least two collaborators' approvals (👍).
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/2301687056

PR-URL: nodejs#43027 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott · 2022-05-10T22:48:44Z

Landed in 761b87a

PR-URL: #43027 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

PR-URL: nodejs/node#43027 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott requested a review from himself65 May 9, 2022 21:00

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 9, 2022

Trott added fast-track PRs that do not need to wait for 48 hours to land. and removed meta Issues and PRs related to the general management of the project. labels May 9, 2022

himself65 approved these changes May 9, 2022

View reviewed changes

Trott commented May 9, 2022

View reviewed changes

Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 9, 2022

tniessen approved these changes May 9, 2022

View reviewed changes

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2022

Trott removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 9, 2022

lpinca approved these changes May 10, 2022

View reviewed changes

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label May 10, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 10, 2022

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label May 10, 2022

himself65 added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels May 10, 2022

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels May 10, 2022

Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. commit-queue Add this label to land a pull request using GitHub Actions. labels May 10, 2022

meta: update .mailmap for recent README name change

761b87a

PR-URL: nodejs#43027 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott force-pushed the update branch from 26987d3 to 761b87a Compare May 10, 2022 22:48

Trott merged commit 761b87a into nodejs:master May 10, 2022

Trott deleted the update branch May 10, 2022 22:48

RafaelGSS mentioned this pull request May 16, 2022

v18.2.0 proposal #43036

Merged

juanarbol mentioned this pull request May 31, 2022

2022-05-XX, Version 16.16.0 'Gallium' (LTS) #43268

Closed

targos pushed a commit that referenced this pull request Jul 12, 2022

meta: update .mailmap for recent README name change

fe8ce4b

PR-URL: #43027 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos pushed a commit that referenced this pull request Jul 31, 2022

meta: update .mailmap for recent README name change

0ce67e2

PR-URL: #43027 Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

targos mentioned this pull request Aug 3, 2022

v16.17.0 release proposal #44098

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

meta: update .mailmap for recent README name change#43027

meta: update .mailmap for recent README name change#43027
Trott merged 1 commit intonodejs:masterfrom
Trott:update

Trott commented May 9, 2022

Uh oh!

github-actions bot commented May 9, 2022

Uh oh!

Trott May 9, 2022

Uh oh!

Trott commented May 9, 2022

Uh oh!

Trott commented May 9, 2022

Uh oh!

nodejs-github-bot commented May 10, 2022

Uh oh!

nodejs-github-bot commented May 10, 2022

Uh oh!

Trott commented May 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Conversation

Trott commented May 9, 2022

Uh oh!

github-actions bot commented May 9, 2022

Uh oh!

Trott May 9, 2022

Choose a reason for hiding this comment

Uh oh!

Trott commented May 9, 2022

Uh oh!

Trott commented May 9, 2022

Uh oh!

nodejs-github-bot commented May 10, 2022

Uh oh!

nodejs-github-bot commented May 10, 2022

Uh oh!

Trott commented May 10, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants