V14.19.2 proposal by juanarbol · Pull Request #42899 · nodejs/node

juanarbol · 2022-04-28T19:48:30Z

Notable Changes

doc:

New release key for Bryan English

Learn more at: #42102
Contributed by Bryan English (@bengl)

npm:

Upgrade npm to v6.14.17.

Learn more at: #42900
Contributed by Ruy Adorno (@ruyadorno)

V8:

V8 had a stack overflow issue affecting the vm module, cherry-picking cc9a8a37445e
from V8 solves this issue.

Learn more at: #41826
Contributed by Gus Caplan (@devsnek)

Using getHeapSnapshot() was causing a Node.js crash due a V8 issue, this is fixed by backporting 367b0c1e7a32
from V8.

Learn more at: #42637
Contributed by Chengzhong Wu (@legendecas)

Commits

[c73ac527d6] - build: set DESTCPU correctly for 'make binary' on Apple Silicon (Chris Heisterkamp) #40147
[dcaed6db24] - build: use ccache in make-v8.sh on ppc64le and s390x (Richard Lau) #42204
[4203d132b1] - child_process: queue pending messages (Erick Wendel) #41221
[a3ebdbfe8f] - deps: upgrade npm to 6.14.17 (Ruy Adorno) #42900
[39e44f8382] - deps: V8: cherry-pick cc9a8a37445e (Gus Caplan) #41826
[b52a268b6f] - deps: V8: cherry-pick 367b0c1e7a32 (legendecas) #42637
[77ba012065] - doc: fix documentation of FileHandle.prototype.appendFile (Antoine du Hamel) #42588
[3d3d7ed1b7] - doc: specify flag needed for JSON and Wasm modules (Rich Trott) #42736
[542d812c93] - doc: use openpgp.org for keyserver examples (Nick Schonning) #39227
[7f2825b1a9] - doc: add release key for Bryan English (Bryan English) #42102
[75302d3dce] - fs: fix write methods param validation and docs (Livia Medeiros) #41677
[d4171e0eac] - stream: resume stream on drain (Robert Nagy) #41848
[de474c8b6f] - worker: do not send message if port is closing (Rich Trott) #42357

Adds Bryan English and his public key to the README for releases. PR-URL: #42102 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>

Previously we would just resume "flowing" the stream without reseting the "paused" state. Fixes this by properly using pause/resume methods for .pipe. Fixes: #41785 PR-URL: #41848 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

nodejs-github-bot · 2022-04-28T19:48:34Z

Review requested:

@nodejs/gyp
@nodejs/modules
@nodejs/streams
@nodejs/v8-update

juanarbol · 2022-04-28T19:50:39Z

cc @nodejs/releasers

I'm not entirely sure about the notable changes; I'm not sure of anything. Please let me know if I missed something or made something wrong.

README.md

common.gypi

doc/changelogs/CHANGELOG_V14.md

aduh95 · 2022-04-28T20:49:19Z

Can we include #42840 as well please?

juanarbol · 2022-04-28T20:52:19Z

Can we include #42840 as well please?

Sure, I forgot to ask, is ok to land without CI? That's why I skiped this one, sorry.

ruyadorno · 2022-04-28T21:02:30Z

I forgot to ask, is ok to land without CI?

You should ideally wait for it.

I know it's a bit of a last minute addition, so it's fine if you prefer not to but I believe it would also be nice to include: #42900

aduh95 · 2022-04-28T21:05:41Z

#42603 is also a good candidate (even though it lacks approval so far): it fixes a process abort, I assume that's the kind of fixes we want to have landed sooner rather than later.

juanarbol · 2022-04-28T21:06:21Z

I forgot to ask, is ok to land without CI?

You should ideally wait for it.

I know it's a bit of a last minute addition, so it's fine if you prefer not to but I believe it would also be nice to include: #42900

No worries, this is a proposal, sure I can add both, and I will keep an eye over #42840 and, #42900.

Does that work for all of us?

juanarbol · 2022-04-28T21:08:52Z

#42603 is also a good candidate (even though it lacks approval so far): it fixes a process abort, I assume that's the kind of fixes we want to have landed sooner rather than later.

Approved, and yes! I'm will include that one as well. Thanks for taking care of kicking CI in both PRs and these suggestions as well.

aduh95 · 2022-04-28T23:36:22Z

FWIW #41855 looks to be ready as well.

legendecas · 2022-04-29T00:27:54Z

nit: my name is Chengzhong Wu ^^

juanarbol · 2022-04-29T04:33:48Z

nit: my name is Chengzhong Wu ^^

Oooh, I'm sorry; It was a bit late for the moment I wrote that; sorry, my mistake. I will fix that one, sorry again

The sks-keyservers.net is no longer listed by DNS PR-URL: #39227 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

If `ccache` is available, use it during V8 builds on ppc64le and s390x. Only create the `gcc` and `g++` shims if necessary. PR-URL: #42204 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Fixes: #42296 PR-URL: #42357 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

PR-URL: #42736 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>

nodejs-github-bot · 2022-05-03T13:43:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43856/

targos · 2022-05-03T13:50:56Z

FWIW I personally dislike using @mention in commit messages because it is a source of unwanted notifications when people cherry-pick commits to other repositories.

juanarbol · 2022-05-03T13:54:14Z

FWIW I personally dislike using @mention in commit messages because it is a source of unwanted notifications when people cherry-pick commits to other repositories.

I can fully understand; sorry about the unwanted noise. Let me fix that one too.

Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (bengl) npm: * Upgrade `npm` to `v6.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (v8/v8@cc9a8a3) from V8 solves this issue. Learn more at: #41826 Contributed by Gus Caplan (devsnek) * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (legendecas) PR-URL: #42899

nodejs-github-bot · 2022-05-03T14:02:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43857/

nodejs-github-bot · 2022-05-03T15:30:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43858/

BethGriggs · 2022-05-03T16:19:51Z

Release build on 3fc68fc: https://ci-release.nodejs.org/job/iojs+release/8438/

BethGriggs · 2022-05-03T18:59:13Z

I'm slightly suspicious of JSONStream-v1.3.5 and acorn-v8.7.1 failing across multiple platforms in CITGM.

BethGriggs · 2022-05-03T19:45:45Z

Running CITGM on v14.19.1 as a comparison - https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2930/console

Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (bengl) npm: * Upgrade `npm` to `v6.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (v8/v8@cc9a8a3) from V8 solves this issue. Learn more at: #41826 Contributed by Gus Caplan (devsnek) * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (legendecas) PR-URL: #42899

nodejs-github-bot · 2022-05-04T03:24:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/43868/ ( ✔️ )

BethGriggs · 2022-05-04T14:05:18Z

Release build on e365bec: https://ci-release.nodejs.org/job/iojs+release/8441/

PR-URL: #42899

Notable Changes doc: * New release key for Bryan English Learn more at: #42102 Contributed by Bryan English (bengl) npm: * Upgrade `npm` to `v6.14.17`. Learn more at: #42900 Contributed by Ruy Adorno (ruyadorno) V8: * V8 had a stack overflow issue affecting the `vm` module, cherry-picking `cc9a8a37445e` (v8/v8@cc9a8a3) from V8 solves this issue. Learn more at: #41826 Contributed by Gus Caplan (devsnek) * Using `getHeapSnapshot()` was causing a Node.js crash due a V8 issue, this is fixed by backporting `367b0c1e7a32` (v8/v8@367b0c1) from V8. Learn more at: #42637 Contributed by Chengzhong Wu (legendecas) PR-URL: #42899

Refs: nodejs/node#42899

bengl and others added 2 commits March 17, 2022 19:31

juanarbol requested review from BethGriggs, bengl and richardlau April 28, 2022 19:48

nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v14.x labels Apr 28, 2022

richardlau reviewed Apr 28, 2022

View reviewed changes

README.md Show resolved Hide resolved

richardlau reviewed Apr 28, 2022

View reviewed changes

common.gypi Outdated Show resolved Hide resolved

BethGriggs reviewed Apr 28, 2022

View reviewed changes

doc/changelogs/CHANGELOG_V14.md Outdated Show resolved Hide resolved

VoltrexKeyva added release Issues and PRs related to Node.js releases. v14.x and removed v14.x lib / src Issues and PRs related to general changes in the lib or src directory. labels Apr 29, 2022

nschonni and others added 4 commits May 1, 2022 16:44

doc: use openpgp.org for keyserver examples

542d812

The sks-keyservers.net is no longer listed by DNS PR-URL: #39227 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

build: use ccache in make-v8.sh on ppc64le and s390x

dcaed6d

If `ccache` is available, use it during V8 builds on ppc64le and s390x. Only create the `gcc` and `g++` shims if necessary. PR-URL: #42204 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

doc: specify flag needed for JSON and Wasm modules

3d3d7ed

PR-URL: #42736 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>

juanarbol force-pushed the v14.19.2-proposal branch from ddd113c to d6288d8 Compare May 3, 2022 13:41

juanarbol force-pushed the v14.19.2-proposal branch from d6288d8 to 3fc68fc Compare May 3, 2022 14:00

BethGriggs approved these changes May 3, 2022

View reviewed changes

richardlau approved these changes May 3, 2022

View reviewed changes

ruyadorno approved these changes May 3, 2022

View reviewed changes

danielleadams approved these changes May 3, 2022

View reviewed changes

github-actions bot mentioned this pull request May 4, 2022

CI Reliability 2022-05-04 nodejs/reliability#271

Open

34 tasks

juanarbol force-pushed the v14.19.2-proposal branch from 3fc68fc to e365bec Compare May 4, 2022 03:23

BethGriggs approved these changes May 4, 2022

View reviewed changes

juanarbol added a commit that referenced this pull request May 4, 2022

Working on v14.19.3

20c299b

PR-URL: #42899

juanarbol merged commit e365bec into v14.x May 4, 2022

juanarbol deleted the v14.19.2-proposal branch May 4, 2022 17:11

juanarbol mentioned this pull request May 4, 2022

Blog: v14.19.2 release post nodejs/nodejs.org#4588

Merged

juanarbol added a commit to juanarbol/nodejs.org that referenced this pull request May 4, 2022

Blog: v14.19.2 release post

c2f2331

Refs: nodejs/node#42899

juanarbol added a commit to juanarbol/nodejs.org that referenced this pull request May 4, 2022

Blog: v14.19.2 release post

4a9d6d1

Refs: nodejs/node#42899

BethGriggs pushed a commit to nodejs/nodejs.org that referenced this pull request May 4, 2022

Blog: v14.19.2 release post (#4588)

0cab6bc

Refs: nodejs/node#42899

github-actions bot mentioned this pull request May 5, 2022

CI Reliability 2022-05-05 nodejs/reliability#272

Open

32 tasks

Uh oh!

Conversation

juanarbol commented Apr 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Notable Changes

Commits

Uh oh!

nodejs-github-bot commented Apr 28, 2022

Uh oh!

juanarbol commented Apr 28, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

aduh95 commented Apr 28, 2022

Uh oh!

juanarbol commented Apr 28, 2022

Uh oh!

ruyadorno commented Apr 28, 2022

Uh oh!

aduh95 commented Apr 28, 2022

Uh oh!

juanarbol commented Apr 28, 2022

Uh oh!

juanarbol commented Apr 28, 2022

Uh oh!

aduh95 commented Apr 28, 2022

Uh oh!

legendecas commented Apr 29, 2022

Uh oh!

juanarbol commented Apr 29, 2022

Uh oh!

nodejs-github-bot commented May 3, 2022

Uh oh!

targos commented May 3, 2022

Uh oh!

juanarbol commented May 3, 2022

Uh oh!

nodejs-github-bot commented May 3, 2022

Uh oh!

nodejs-github-bot commented May 3, 2022

Uh oh!

BethGriggs commented May 3, 2022

Uh oh!

BethGriggs commented May 3, 2022

Uh oh!

BethGriggs commented May 3, 2022

Uh oh!

nodejs-github-bot commented May 4, 2022 • edited by juanarbol Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BethGriggs commented May 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

juanarbol commented Apr 28, 2022 •

edited

Loading

nodejs-github-bot commented May 4, 2022 •

edited by juanarbol

Loading