[v16.x backport] test: improve code coverage for streams/duplexify#42788
Closed
ErickWendel wants to merge 1 commit intonodejs:v16.x-stagingfrom
Closed
[v16.x backport] test: improve code coverage for streams/duplexify#42788ErickWendel wants to merge 1 commit intonodejs:v16.x-stagingfrom
ErickWendel wants to merge 1 commit intonodejs:v16.x-stagingfrom
Conversation
nodejs-github-bot
added
needs-ci
danielleadams
added
the
fast-track
danielleadams
approved these changes
Apr 20, 2022
Contributor
|
Fast-track has been requested by @danielleadams. Please 👍 to approve. |
Collaborator
Collaborator
Collaborator
This was referenced Apr 21, 2022
This was referenced Apr 24, 2022
Member
Author
|
is anything missing to approve on this PR? |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced May 30, 2022
Collaborator
This was referenced Jun 1, 2022
Collaborator
Contributor
|
@nodejs/collaborators would anyone else be able to review this? |
cclauss
approved these changes
Jun 23, 2022
himself65
approved these changes
Jun 23, 2022
Collaborator
Contributor
|
@ErickWendel I just realized the base of this PR is pointed to |
Member
Author
Oh. I'm sorry about it. I'll do. This week is being crazy here but I'll trying doing it by the weekend |
Member
Author
|
hey just a heads up. I'm back from vacations so I'll be working on this feature this week o/ |
ErickWendel
force-pushed
the
erick/backport-streams-improve-code-coverage
branch
from
7fd01a6 to
9bd0c30
Compare
ErickWendel
force-pushed
the
erick/backport-streams-improve-code-coverage
branch
from
9bd0c30 to
5bedc83
Compare
Member
Author
|
Ready to go now 🤩 |
danielleadams
force-pushed
the
v16.x-staging
branch
from
bd952ea to
01e7d1f
Compare
Trott
force-pushed
the
erick/backport-streams-improve-code-coverage
branch
from
5bedc83 to
e8d4384
Compare
Member
|
Thank you @ErickWendel. Landed in 4aa4f7c |
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
PR-URL: nodejs/node#41862 Backport-PR-URL: nodejs/node#42788 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #41862
/cc @danielleadams