[v14.x backport] build: set DESTCPU correctly for 'make binary' on Apple Silicon#41855
Closed
evanlucas wants to merge 1 commit intonodejs:v14.x-stagingfrom
Closed
[v14.x backport] build: set DESTCPU correctly for 'make binary' on Apple Silicon#41855evanlucas wants to merge 1 commit intonodejs:v14.x-stagingfrom
evanlucas wants to merge 1 commit intonodejs:v14.x-stagingfrom
Conversation
nodejs-github-bot
added
build
evanlucas
pushed a commit
to evanlucas/node
that referenced
this pull request
Feb 5, 2022
PR-URL: nodejs#40147 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Backport-PR-URL: nodejs#41855
evanlucas
force-pushed
the
backport-40147-to-v14.x
branch
from
05c2a15 to
68b4391
Compare
evanlucas
requested review from
jasnell,
lpinca,
mhdawson,
richardlau and
targos
lpinca
approved these changes
Feb 23, 2022
targos
approved these changes
Feb 23, 2022
evanlucas
added
the
commit-queue
richardlau
force-pushed
the
v14.x-staging
branch
2 times, most recently
from
30ba86c to
7f2825b
Compare
PR-URL: nodejs#40147 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Backport-PR-URL: nodejs#41855
evanlucas
force-pushed
the
backport-40147-to-v14.x
branch
from
68b4391 to
1c9ebe3
Compare
Collaborator
evanlucas
removed
needs-ci
This was referenced Apr 19, 2022
Collaborator
Collaborator
Merged
richardlau
approved these changes
Apr 29, 2022
Member
|
Landed in c73ac52 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: #40147
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Michael Dawson midawson@redhat.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Richard Lau rlau@redhat.com
This fixes building on Apple Silicon on v14.x.