http: remove 'data' and 'end' listener if client parser error#40244
Closed
mcollina wants to merge 1 commit intonodejs:masterfrom
Closed
http: remove 'data' and 'end' listener if client parser error#40244mcollina wants to merge 1 commit intonodejs:masterfrom
mcollina wants to merge 1 commit intonodejs:masterfrom
Conversation
There might be the case of some more data coming through after the parser has returned an error and we have destroyed the socket. We should also be removing the 'data' event handler. Fixes: nodejs#40242
nodejs-github-bot
added
http
Collaborator
ronag
approved these changes
Sep 28, 2021
Member
Author
|
cc @terreng |
18 tasks
Collaborator
mcollina
added
the
author ready
17 tasks
jasnell
approved these changes
Sep 30, 2021
mcollina
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Contributor
|
Landed in 4f3eda6...140b25a |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 30, 2021
There might be the case of some more data coming through after the parser has returned an error and we have destroyed the socket. We should also be removing the 'data' event handler. Fixes: #40242 PR-URL: #40244 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Oct 1, 2021
targos
pushed a commit
that referenced
this pull request
Oct 4, 2021
There might be the case of some more data coming through after the parser has returned an error and we have destroyed the socket. We should also be removing the 'data' event handler. Fixes: #40242 PR-URL: #40244 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Oct 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There might be the case of some more data coming through after
the parser has returned an error and we have destroyed the socket.
We should also be removing the 'data' event handler.
Fixes: #40242