async_hooks: refactor to avoid unsafe array iteration

[aduh95]

No description provided.

[TrySound]

What's wrong with modern syntax?

[aduh95]

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/916/ (queued, will 404 until it starts).

[aduh95]

What's wrong with modern syntax?

Nothing wrong with the syntax, the problem is with array iteration which relies on user-mutables methods:

delete Array.prototype[Symbol.iterator];
const [a, b, c] = [1,2,3];

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/35811/

[RaisinTen]

@aduh95 The benchmark didn't run properly. Here is the new link:
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/918/
Hope there are no regressions! 🤞

[aduh95]

The benchmark stops working after two minutes… I'm not sure if it's a problem with our CI or the benchmark itself.

I'm splitting it into several runs to see if that helps:
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/920/
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/921/
https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/922/

[aduh95]

No significant perf improvements or regressions.

Details

                                                                            confidence improvement accuracy (*)    (**)   (***)
async_hooks/gc-tracking.jsmethod='trackingDisabled' n=1000000                              -4.16 %       ±8.67% ±11.59% ±15.19%
async_hooks/gc-tracking.jsmethod='trackingEnabled' n=1000000                               -1.90 %       ±5.38%  ±7.16%  ±9.32%
async_hooks/gc-tracking.jsmethod='trackingEnabledWithDestroyHook' n=1000000                 0.46 %       ±3.89%  ±5.17%  ±6.73%

                                                                                             confidence improvement accuracy (*)    (**)   (***)
async_hooks/http-server.jsduration=5 connections=50 asyncHooks='after' benchmarker='wrk'                    -1.80 %      ±13.73% ±24.39% ±51.16%
async_hooks/http-server.jsduration=5 connections=50 asyncHooks='all' benchmarker='wrk'                       0.12 %      ±14.36% ±23.32% ±42.11%
async_hooks/http-server.jsduration=5 connections=50 asyncHooks='before' benchmarker='wrk'                    1.73 %      ±12.36% ±19.18% ±32.09%
async_hooks/http-server.jsduration=5 connections=50 asyncHooks='disabled' benchmarker='wrk'                  7.56 %      ±20.85% ±36.49% ±74.63%
async_hooks/http-server.jsduration=5 connections=50 asyncHooks='init' benchmarker='wrk'                      0.33 %       ±8.25% ±12.79% ±21.38%
async_hooks/http-server.jsduration=5 connections=50 asyncHooks='none' benchmarker='wrk'                     -6.26 %      ±12.16% ±19.96% ±36.65%
async_hooks/http-server.jsduration=5 connections=500 asyncHooks='after' benchmarker='wrk'                    6.97 %      ±26.03% ±45.59% ±93.38%
async_hooks/http-server.jsduration=5 connections=500 asyncHooks='all' benchmarker='wrk'                      7.82 %      ±15.04% ±31.93% ±89.26%
async_hooks/http-server.jsduration=5 connections=500 asyncHooks='before' benchmarker='wrk'                  -2.09 %      ±16.85% ±25.64% ±41.50%
async_hooks/http-server.jsduration=5 connections=500 asyncHooks='disabled' benchmarker='wrk'                 7.77 %      ±17.60% ±28.56% ±51.49%
async_hooks/http-server.jsduration=5 connections=500 asyncHooks='init' benchmarker='wrk'                     0.82 %      ±13.66% ±20.69% ±33.26%
async_hooks/http-server.jsduration=5 connections=500 asyncHooks='none' benchmarker='wrk'                    -8.57 %      ±20.70% ±37.58% ±81.69%

                                                                  confidence improvement accuracy (*)   (**)  (***)
async_hooks/promises.jsasyncHooks='disabled' n=1000000                           -0.93 %       ±1.72% ±2.29% ±2.98%
async_hooks/promises.jsasyncHooks='enabled' n=1000000                            -1.14 %       ±1.67% ±2.22% ±2.89%
async_hooks/promises.jsasyncHooks='enabledWithDestroy' n=1000000                  0.85 %       ±2.15% ±2.87% ±3.75%
async_hooks/promises.jsasyncHooks='enabledWithInitOnly' n=1000000                -0.40 %       ±1.67% ±2.23% ±2.91%

[aduh95]

Landed in f8853dd