[v13.x backport] stream: eos make const state const#32178
Closed
ronag wants to merge 1 commit intonodejs:v13.x-stagingfrom
Closed
[v13.x backport] stream: eos make const state const#32178ronag wants to merge 1 commit intonodejs:v13.x-stagingfrom
ronag wants to merge 1 commit intonodejs:v13.x-stagingfrom
Conversation
writable & readable is based on type and is not actual state, treat them as such. PR-URL: nodejs#32031 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Backport-PR-URL: nodejs#32178
ronag
force-pushed
the
backport-32031-to-v13.x
branch
from
aa6df82 to
18e5e53
Compare
Collaborator
Contributor
|
landed in f263659 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: #32031
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes