docs: update collaborator guide with citgm instructions#31549
Closed
ronag wants to merge 6 commits intonodejs:masterfrom
Closed
docs: update collaborator guide with citgm instructions#31549ronag wants to merge 6 commits intonodejs:masterfrom
ronag wants to merge 6 commits intonodejs:masterfrom
Conversation
Member
Author
|
@nodejs/documentation |
Member
Author
|
credit to @Trott :) |
richardlau
reviewed
Jan 28, 2020
richardlau
reviewed
Jan 28, 2020
richardlau
approved these changes
Jan 28, 2020
Member
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
Thanks. LGTM if you add the new section to the TOC.
Member
|
(And for whoever lands this the subsystem is usually |
ronag
added
the
author ready
jasnell
approved these changes
Jan 30, 2020
Trott
reviewed
Jan 30, 2020
Trott
reviewed
Jan 30, 2020
Trott
reviewed
Jan 30, 2020
Trott
reviewed
Jan 30, 2020
Trott
reviewed
Jan 30, 2020
Trott
reviewed
Jan 30, 2020
Trott
approved these changes
Jan 30, 2020
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM with or without the little nits I left. Thanks for doing this!
Co-Authored-By: Rich Trott <rtrott@gmail.com>
Co-Authored-By: Rich Trott <rtrott@gmail.com>
lpinca
approved these changes
Jan 30, 2020
BethGriggs
approved these changes
Jan 30, 2020
Member
Author
|
Landed in 1d95111 |
ronag
added a commit
that referenced
this pull request
Jan 30, 2020
PR-URL: #31549 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
codebytere
pushed a commit
that referenced
this pull request
Feb 17, 2020
PR-URL: #31549 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 15, 2020
PR-URL: #31549 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
PR-URL: #31549 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 30, 2020
PR-URL: #31549 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds more information about running CITGM jobs.
Note, not sure what commit prefix to use in the root?
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes