doc: guide - using valgrind to debug memory leaks#31501
Closed
mhdawson wants to merge 73 commits intonodejs:masterfrom
Closed
doc: guide - using valgrind to debug memory leaks#31501mhdawson wants to merge 73 commits intonodejs:masterfrom
mhdawson wants to merge 73 commits intonodejs:masterfrom
Conversation
Add doc for using valgrind to debug native memory leaks. Started writing this up as part of an effort in the Diagnostic WG but think it's better to have it in the core guides and then be referenced by the docs in the Diagnostic WG repo. For more details on the Diagnostic WG effort see nodejs/diagnostics#254 (comment) This guide is related to `/step3 - using_native_tools.md`
Member
Author
|
@gireeshpunathil, @pmarton FYI |
mscdex
reviewed
Jan 24, 2020
mscdex
reviewed
Jan 24, 2020
mscdex
reviewed
Jan 24, 2020
mscdex
reviewed
Jan 24, 2020
mscdex
reviewed
Jan 24, 2020
mscdex
reviewed
Jan 24, 2020
mscdex
reviewed
Jan 24, 2020
mscdex
reviewed
Jan 24, 2020
mscdex
reviewed
Jan 24, 2020
mscdex
reviewed
Jan 24, 2020
mscdex
reviewed
Jan 24, 2020
mscdex
reviewed
Jan 24, 2020
mscdex
reviewed
Jan 24, 2020
mscdex
reviewed
Jan 24, 2020
mscdex
reviewed
Jan 24, 2020
mscdex
reviewed
Jan 24, 2020
mscdex
reviewed
Jan 24, 2020
mscdex
reviewed
Jan 24, 2020
mscdex
reviewed
Jan 24, 2020
mscdex
reviewed
Jan 24, 2020
mscdex
reviewed
Jan 24, 2020
mscdex
reviewed
Jan 24, 2020
mscdex
reviewed
Jan 24, 2020
mscdex
reviewed
Jan 24, 2020
mscdex
reviewed
Jan 24, 2020
mscdex
reviewed
Jan 24, 2020
Member
Author
|
@mscdex, @addaleax. @Trott, @cjihrig, @gireeshpunathil thanks for the review and all the suggestions. Updated to incorporate them. |
hekike
approved these changes
Jan 27, 2020
XhmikosR
reviewed
Jan 29, 2020
| A Node.js process may run out of memory due to excessive consumption of | ||
| native memory. Native Memory is memory which is not managed by the | ||
| V8 Garbage collector and is allocated either by the Node.js runtime, its | ||
| dependencies or native [addons](://nodejs.org/docs/latest/api/n-api.html). |
Contributor
There was a problem hiding this comment.
Is this link right? It's missing the protocol
Member
Author
There was a problem hiding this comment.
Thanks for catching that
lundibundi
reviewed
Jan 31, 2020
Co-Authored-By: Denys Otrishko <9109612+lundibundi@users.noreply.github.com>
Co-Authored-By: Denys Otrishko <9109612+lundibundi@users.noreply.github.com>
Co-Authored-By: Denys Otrishko <9109612+lundibundi@users.noreply.github.com>
Co-Authored-By: Denys Otrishko <9109612+lundibundi@users.noreply.github.com>
lundibundi
approved these changes
Feb 1, 2020
Co-Authored-By: Denys Otrishko <shishugi@gmail.com>
jasnell
reviewed
Feb 12, 2020
| dependencies or native [addons](https://nodejs.org/docs/latest/api/n-api.html). | ||
|
|
||
| This guide provides information on how to use valgrind to investigate these | ||
| issues. |
Member
There was a problem hiding this comment.
May be worthwhile stressing the point that this is Linux only
jasnell
approved these changes
Feb 12, 2020
mhdawson
commented
Feb 14, 2020
mhdawson
added a commit
that referenced
this pull request
Feb 14, 2020
Add doc for using valgrind to debug native memory leaks. Started writing this up as part of an effort in the Diagnostic WG but think it's better to have it in the core guides and then be referenced by the docs in the Diagnostic WG repo. For more details on the Diagnostic WG effort see nodejs/diagnostics#254 (comment) This guide is related to `/step3 - using_native_tools.md` PR-URL: #31501 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
Author
|
Landed in 89c1aa3 |
codebytere
pushed a commit
that referenced
this pull request
Feb 27, 2020
Add doc for using valgrind to debug native memory leaks. Started writing this up as part of an effort in the Diagnostic WG but think it's better to have it in the core guides and then be referenced by the docs in the Diagnostic WG repo. For more details on the Diagnostic WG effort see nodejs/diagnostics#254 (comment) This guide is related to `/step3 - using_native_tools.md` PR-URL: #31501 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 15, 2020
Add doc for using valgrind to debug native memory leaks. Started writing this up as part of an effort in the Diagnostic WG but think it's better to have it in the core guides and then be referenced by the docs in the Diagnostic WG repo. For more details on the Diagnostic WG effort see nodejs/diagnostics#254 (comment) This guide is related to `/step3 - using_native_tools.md` PR-URL: #31501 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
Add doc for using valgrind to debug native memory leaks. Started writing this up as part of an effort in the Diagnostic WG but think it's better to have it in the core guides and then be referenced by the docs in the Diagnostic WG repo. For more details on the Diagnostic WG effort see nodejs/diagnostics#254 (comment) This guide is related to `/step3 - using_native_tools.md` PR-URL: #31501 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 30, 2020
Add doc for using valgrind to debug native memory leaks. Started writing this up as part of an effort in the Diagnostic WG but think it's better to have it in the core guides and then be referenced by the docs in the Diagnostic WG repo. For more details on the Diagnostic WG effort see nodejs/diagnostics#254 (comment) This guide is related to `/step3 - using_native_tools.md` PR-URL: #31501 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add doc for using valgrind to debug native
memory leaks.
Started writing this up as part of an effort
in the Diagnostic WG but think it's better
to have it in the core guides and then be referenced
by the docs in the Diagnostic WG repo.
For more details on the Diagnostic WG effort see
nodejs/diagnostics#254 (comment)
This guide is related to
/step3 - using_native_tools.mdChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes