tools: sync gyp code base with node-gyp repo#30563
Closed
targos wants to merge 1 commit intonodejs:masterfrom
Closed
tools: sync gyp code base with node-gyp repo#30563targos wants to merge 1 commit intonodejs:masterfrom
targos wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
build
Member
Author
|
PR in nodejs/node-gyp: nodejs/node-gyp#1975 |
Collaborator
Collaborator
ryzokuken
approved these changes
Nov 26, 2019
Contributor
ryzokuken
left a comment
ryzokuken
left a comment
There was a problem hiding this comment.
Hopefully I've seen everything, just a bunch of comments. Likely all the issues need to be picked up in the gyp3 repo instead, so feel free to ignore 'em and merge. Thanks for doing this!
cclauss
reviewed
Nov 27, 2019
cclauss
reviewed
Nov 27, 2019
cclauss
approved these changes
Nov 27, 2019
Contributor
|
Do we really want to get rid of tools/gyp/gyptest.py? Perhaps it should be renamed to tools/gyp/test_gyp.py so that pytest will discover it and modify it to run in our test cycles. |
Member
Author
|
@cclauss, that file was removed in nodejs/node-gyp#1458 |
2 tasks
Collaborator
BridgeAR
added
the
author ready
Collaborator
Contributor
|
@targos what's left to be addressed here? |
Member
Author
Trott
removed
the
author ready
4 tasks
Collaborator
Member
Author
|
Other PR landed on node-gyp. This should be ready to go. |
Collaborator
targos
added a commit
that referenced
this pull request
Feb 21, 2020
PR-URL: #30563 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
Author
|
Landed in cf00961 |
4 tasks
codebytere
pushed a commit
that referenced
this pull request
Feb 27, 2020
PR-URL: #30563 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
63 tasks
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 15, 2020
PR-URL: #30563 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
PR-URL: #30563 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 30, 2020
PR-URL: #30563 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
BaochengSu
pushed a commit
to BaochengSu/node
that referenced
this pull request
Oct 20, 2020
PR-URL: nodejs#30563 Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Christian Clauss <cclauss@me.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This syncs the gyp code base so that it is identical to the one in nodejs/node-gyp.
This was done by removing the code in nodejs/node-gyp, copying from nodejs/node and then manually reviewing and adapting the diff.