src: runMicrotasks should check before running too#29581
Closed
nornagon wants to merge 1 commit intonodejs:masterfrom
Closed
src: runMicrotasks should check before running too#29581nornagon wants to merge 1 commit intonodejs:masterfrom
nornagon wants to merge 1 commit intonodejs:masterfrom
Conversation
This is a continuation of nodejs#29434, rewriting the last remaining call to RunMicrotasks.
nodejs-github-bot
added
the
c++
Contributor
Author
|
cc @codebytere who wrote the original patch for this. |
jasnell
approved these changes
Sep 16, 2019
devsnek
approved these changes
Sep 16, 2019
codebytere
approved these changes
Sep 16, 2019
Trott
added
the
author ready
Collaborator
JungMinu
approved these changes
Sep 17, 2019
devnexen
approved these changes
Sep 17, 2019
BridgeAR
approved these changes
Sep 18, 2019
Collaborator
6 tasks
Collaborator
Trott
pushed a commit
that referenced
this pull request
Sep 23, 2019
This is a continuation of #29434, rewriting the last remaining call to RunMicrotasks. PR-URL: #29581 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Member
|
Landed in 4ef3ccb |
targos
pushed a commit
that referenced
this pull request
Sep 23, 2019
This is a continuation of #29434, rewriting the last remaining call to RunMicrotasks. PR-URL: #29581 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 25, 2019
This is a continuation of #29434, rewriting the last remaining call to RunMicrotasks. PR-URL: #29581 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Sep 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of #29434, rewriting the last remaining call to RunMicrotasks.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes