doc: async_hooks.createHook resolvePromise option#29405
Closed
bnoordhuis wants to merge 1 commit intonodejs:masterfrom
Closed
doc: async_hooks.createHook resolvePromise option#29405bnoordhuis wants to merge 1 commit intonodejs:masterfrom
bnoordhuis wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
async_hooks
devnexen
approved these changes
Sep 2, 2019
targos
approved these changes
Sep 2, 2019
Member
targos
left a comment
targos
left a comment
There was a problem hiding this comment.
s/resolvePromise/promiseResolve/ in the commit message
cjihrig
approved these changes
Sep 2, 2019
Document the `promiseResolve` option to `async_hooks.createHook()`. This seems to have been overlooked in commit b605b15 ("async_hooks: support promise resolve hook") from September 2017. It is documented elsewhere in the async_hooks API documentation, except where you actually pass it in.
bnoordhuis
force-pushed
the
promiseresolve
branch
from
cd70658 to
94a75ee
Compare
Member
Author
Wups, updated! |
lpinca
approved these changes
Sep 3, 2019
jasnell
approved these changes
Sep 3, 2019
Member
danbev
added
the
author ready
danbev
pushed a commit
that referenced
this pull request
Sep 6, 2019
Document the `promiseResolve` option to `async_hooks.createHook()`. This seems to have been overlooked in commit b605b15 ("async_hooks: support promise resolve hook") from September 2017. It is documented elsewhere in the async_hooks API documentation, except where you actually pass it in. PR-URL: #29405 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
|
Landed in 9c57e4d. |
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
Document the `promiseResolve` option to `async_hooks.createHook()`. This seems to have been overlooked in commit b605b15 ("async_hooks: support promise resolve hook") from September 2017. It is documented elsewhere in the async_hooks API documentation, except where you actually pass it in. PR-URL: #29405 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Sep 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document the
resolvePromiseoption toasync_hooks.createHook().This seems to have been overlooked in commit b605b15 ("async_hooks:
support promise resolve hook") from September 2017.
It is documented elsewhere in the async_hooks API documentation, except
where you actually pass it in.