Closed
Conversation
nodejs-github-bot
added
the
lib / src
jasnell
approved these changes
Aug 26, 2019
Collaborator
Trott
previously requested changes
Aug 29, 2019
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
Multiple test-policy-* failures on all platforms in CI. Marking with "Request changes" so no one accidentally lands it until those are fixed. Feel free to dismiss this request-for-changes once the tests are passing.
devnexen
reviewed
Aug 30, 2019
lib/internal/policy/sri.js
Outdated
Contributor
There was a problem hiding this comment.
Could it be one whole condition with below ?
Member
Author
There was a problem hiding this comment.
could be yea, i think readability is better as is but if requested to change I could
Collaborator
bmeck
force-pushed
the
policy-cleanup
branch
from
bcf133b to
ac3298a
Compare
bmeck
added a commit
that referenced
this pull request
Sep 3, 2019
PR-URL: #29322 Reviewed-By: James M Snell <jasnell@gmail.com>
Member
Author
|
Landed in 6ce87c0 |
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
PR-URL: #29322 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Sep 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleanup: Use more Maps instead of object dictionaries, use private fields instead of WeakMaps, minor error message cleanup.
Perf: Makes redirects lazier for parsing which was proving to be a large amount of work for relative URL strings and adds a parse cache.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes