Closed
Conversation
ronag
force-pushed
the
http-refactor-keep-alive
branch
5 times, most recently
from
71d9bb8 to
6e0f839
Compare
Member
Author
|
ping @benjamingr |
benjamingr
approved these changes
Jul 18, 2019
Member
benjamingr
left a comment
benjamingr
left a comment
There was a problem hiding this comment.
This is definitely a readability improvement IMO and it makes more sense for the destroySoon stuff to happen in the responseEnd and not responseKeepAlive method.
Thanks for this 🙏
trivikr
approved these changes
Jul 18, 2019
Member
|
@nodejs/http While not strictly necessary, another review or two here would be good. |
Member
|
This would need a rebase. |
Collaborator
ronag
force-pushed
the
http-refactor-keep-alive
branch
2 times, most recently
from
350b4d7 to
625a60a
Compare
Member
Author
|
rebased |
benjamingr
added
the
author ready
Member
Member
|
Unfortunately it needs another rebase :( |
Member
Author
|
Rebased |
ronag
force-pushed
the
http-refactor-keep-alive
branch
from
625a60a to
51b9daa
Compare
Collaborator
Member
Member
|
CITGM is ok. |
jasnell
approved these changes
Sep 11, 2019
Collaborator
Member
|
There seems to be CI failures on specific environments... cc @Trott. |
Collaborator
Member
|
Landed in 627bb6b |
Trott
pushed a commit
that referenced
this pull request
Sep 16, 2019
This tries to simplify the code and make it easier to understand. Took me a while to get my head around the previous implementation. Also minor perf improvement. PR-URL: #28700 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Sep 20, 2019
This tries to simplify the code and make it easier to understand. Took me a while to get my head around the previous implementation. Also minor perf improvement. PR-URL: #28700 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Sep 25, 2019
This tries to simplify the code and make it easier to understand. Took me a while to get my head around the previous implementation. Also minor perf improvement. PR-URL: #28700 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Sep 25, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tries to simplify the code and make it easier to understand. Took me a while to get my head around the previous implementation.
Also minor perf improvement.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes