test: don't use deprecated crypto.fips property#28509
Closed
bnoordhuis wants to merge 1 commit intonodejs:masterfrom
Closed
test: don't use deprecated crypto.fips property#28509bnoordhuis wants to merge 1 commit intonodejs:masterfrom
bnoordhuis wants to merge 1 commit intonodejs:masterfrom
Conversation
`crypto.fips` was deprecated in commit 6e7992e ("crypto: docs-only deprecate crypto.fips, replace") but its usage in `common.hasFipsCrypto` seems to have been overlooked.
Collaborator
cjihrig
approved these changes
Jul 2, 2019
Trott
approved these changes
Jul 2, 2019
richardlau
approved these changes
Jul 2, 2019
2 tasks
addaleax
approved these changes
Jul 2, 2019
Trott
added
the
author ready
trivikr
approved these changes
Jul 2, 2019
lpinca
approved these changes
Jul 2, 2019
BridgeAR
approved these changes
Jul 4, 2019
Contributor
|
Landed in de10602. |
danbev
pushed a commit
that referenced
this pull request
Jul 5, 2019
`crypto.fips` was deprecated in commit 6e7992e ("crypto: docs-only deprecate crypto.fips, replace") but its usage in `common.hasFipsCrypto` seems to have been overlooked. PR-URL: #28509 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos
pushed a commit
that referenced
this pull request
Jul 20, 2019
`crypto.fips` was deprecated in commit 6e7992e ("crypto: docs-only deprecate crypto.fips, replace") but its usage in `common.hasFipsCrypto` seems to have been overlooked. PR-URL: #28509 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Jul 23, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crypto.fipswas deprecated in commit 6e7992e ("crypto: docs-onlydeprecate crypto.fips, replace") but its usage in
common.hasFipsCryptoseems to have been overlooked.