test: fix expectation in test-bootstrap-modules#27727
Closed
MylesBorins wants to merge 1 commit intonodejs:v10.x-stagingfrom
Closed
test: fix expectation in test-bootstrap-modules#27727MylesBorins wants to merge 1 commit intonodejs:v10.x-stagingfrom
MylesBorins wants to merge 1 commit intonodejs:v10.x-stagingfrom
Conversation
Collaborator
addaleax
approved these changes
May 16, 2019
Member
|
@MylesBorins The PR you linked can’t land on v10.x because the underlying functionality in V8 is lacking – changing the value in the test should be more than okay (I’ve sometimes done that directly in the commit that changed the value while backporting) |
Contributor
Author
|
Landed in d19c2c5 |
Merged
This was referenced May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current failure on v10.x-staging, exact same thing that we fixed in #25112
it seems like the new item in the list is
Internal Binding contextifywhich I believe was introduced in #27124@guybedford @ryzokuken
it looks like @addaleax marked the original PR #21573 as "do-not-land-v10.x"... is there an issue with the backport landing in 10.16.0?