lib: replace --diagnostic-report-* with --report-*

[joyeecheung]

In the code base the word report is almost only used to refer to
the diagnostic report when it's a noun, and its programmable
interface process.report() is not prefixed, so report should be
unambiguous enough to use without diagnostic.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

[nodejs-github-bot]

Lite-CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3304

[joyeecheung]

cc @nodejs/diagnostics

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22562/

[mscdex]

I wonder if for consistency this might be a good time to change a couple of the flag suffixes to something shorter like in #27306, i.e. --report-dir and --report-name, instead of --report-directory and --report-filename respectively?

[joyeecheung]

@mscdex I think --report-dir makes sense considering we already have --icu-data-dir, --report-filename is triciker, because we don't have precedence. Another thing to take into account is:

path.format({dir: 'test', 'name': 'report.json'});  // test/report.json on UNIX
path.parse('test/report.json');
// { root: '',
//  dir: 'test',
//  base: 'report.json',
//  ext: '.json',
//  name: 'report' }

And, the API of process.report() still takes directory and filename. I think we could leave that to a separate patch to discuss and make sure we have a configuration format consistent with what we have in core? Report is still experimental, so there is no need to rush yet.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22618/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/22621/

[joyeecheung]

Landed in 94adfe9