lib,src,doc: add --heapsnapshot-signal CLI flag#27133
Merged
cjihrig merged 1 commit intonodejs:masterfrom Apr 12, 2019
Merged
Conversation
Collaborator
joyeecheung
reviewed
Apr 8, 2019
joyeecheung
reviewed
Apr 8, 2019
jasnell
approved these changes
Apr 8, 2019
Member
jasnell
left a comment
There was a problem hiding this comment.
LGTM with @joyeecheung's comment addressed
Member
|
Does this work on Windows? (I'm guessing not, at least based on the equivalent test in node/test/report/test-report-config.js Lines 63 to 87 in cc4e8e0 |
bnoordhuis
reviewed
Apr 8, 2019
sam-github
approved these changes
Apr 8, 2019
richardlau
reviewed
Apr 11, 2019
e89e9d6 to
2520bf7
Compare
Collaborator
richardlau
approved these changes
Apr 11, 2019
Collaborator
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/22395/ EDIT(cjihrig): CI was green. |
addaleax
approved these changes
Apr 12, 2019
This flag allows heap snapshots to be captured without modifying application code. PR-URL: nodejs#27133 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Apr 23, 2019
This was referenced Apr 23, 2019
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag allows heap snapshots to be captured without modifying application code. IMO, this is a big part of the "heapdump in core" use case.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes