[v8.x-backport] n-api: mark thread-safe function as stable#25648
Closed
gabrielschulhof wants to merge 2 commits intonodejs:v8.x-stagingfrom
Closed
[v8.x-backport] n-api: mark thread-safe function as stable#25648gabrielschulhof wants to merge 2 commits intonodejs:v8.x-stagingfrom
gabrielschulhof wants to merge 2 commits intonodejs:v8.x-stagingfrom
Conversation
nodejs-github-bot
added
c++
gabrielschulhof
force-pushed
the
un-experimental-tsfn-v8.x
branch
from
d4728e7 to
ca8a70e
Compare
gabrielschulhof
added
the
semver-minor
mhdawson
reviewed
Jan 23, 2019
gabrielschulhof
force-pushed
the
un-experimental-tsfn-v8.x
branch
from
ca8a70e to
94a1637
Compare
gabrielschulhof
changed the title
Contributor
Author
Contributor
Author
|
@mhdawson I have now backported the commit that introduces the guards. |
mhdawson
reviewed
Jan 28, 2019
doc/api/n-api.md
Outdated
Member
There was a problem hiding this comment.
As an aside do we need to update this table, at least in master?
Contributor
Author
There was a problem hiding this comment.
Yeah, I think we do.
* Move `napi_get_uv_event_loop` into the `NAPI_VERSION >= 2` section * Move `napi_open_callback_scope`, `napi_close_callback_scope`, `napi_fatal_exception`, `napi_add_env_cleanup_hook`, and `napi_remove_env_cleanup_hook` into the `NAPI_VERSION >= 3` section * Added a missing `added` property to `napi_get_uv_event_loop` in the docs * Added a `napiVersion` property to the docs and updated the parser and generator to use it. * Added usage documentation PR-URL: nodejs#19962 Backport-PR-URL: nodejs#25648 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Fixes: nodejs#24249 PR-URL: nodejs#25556 Backport-PR-URL: nodejs#25633 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gabrielschulhof
force-pushed
the
un-experimental-tsfn-v8.x
branch
from
94a1637 to
ad9c154
Compare
Contributor
Author
|
Weird ... github said there was a conflict in 4 different files, but I rebased and there was no conflict at all. |
Contributor
Author
Contributor
Author
BethGriggs
pushed a commit
that referenced
this pull request
Mar 20, 2019
* Move `napi_get_uv_event_loop` into the `NAPI_VERSION >= 2` section * Move `napi_open_callback_scope`, `napi_close_callback_scope`, `napi_fatal_exception`, `napi_add_env_cleanup_hook`, and `napi_remove_env_cleanup_hook` into the `NAPI_VERSION >= 3` section * Added a missing `added` property to `napi_get_uv_event_loop` in the docs * Added a `napiVersion` property to the docs and updated the parser and generator to use it. * Added usage documentation PR-URL: #19962 Backport-PR-URL: #25648 Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Member
|
Landed on v8.x-staging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove NAPI_EXPERIMENTAL guard from around N-API thread-safe function
APIs.
Unlike in later versions of Node.js in this version the
NAPI_EXPERIMENTALguard cannot be replaced with#if NAPI_VERSION >= 4because the N-API versioning commit (8476053) was not backported. So, the only option is to drop the guard.Fixes: #24249
PR-URL: #25556
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes