Closed
Conversation
- Less files to maintain. - We don't use them. - We build with GN to run V8 tests. Fixes: nodejs#25095 Refs: nodejs#25010
nodejs-github-bot
added
the
v8 engine
richardlau
approved these changes
Dec 17, 2018
Member
Author
Trott
added
the
author ready
danbev
approved these changes
Dec 18, 2018
jasnell
approved these changes
Dec 18, 2018
watilde
approved these changes
Dec 18, 2018
Member
Author
|
Landed in f0e4609 |
targos
added a commit
that referenced
this pull request
Dec 20, 2018
- Less files to maintain. - We don't use them. - We build with GN to run V8 tests. Fixes: #25095 Refs: #25010 PR-URL: #25097 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
- Less files to maintain. - We don't use them. - We build with GN to run V8 tests. Fixes: nodejs#25095 Refs: nodejs#25010 PR-URL: nodejs#25097 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
This was referenced Apr 23, 2019
This was referenced Sep 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #25095
Refs: #25010
/cc @ryzokuken