Conversation
Contributor
Author
|
Ohh sorry I created the branch on this repo. I'm hoping to fast track this, so we won't miss information in CI. /CC @nodejs/build-files |
richardlau
reviewed
Sep 18, 2018
| if defined config_flags set configure_flags=%configure_flags% %config_flags% | ||
| if defined target_arch set configure_flags=%configure_flags% --dest-cpu=%target_arch% | ||
| if defined openssl_no_asm set configure_flags=%configure_flags% --openssl-no-asm | ||
| if defined DEBUG_HELPER set configure_flags=%configure_flags% --verbose |
Contributor
Author
richardlau
approved these changes
Sep 18, 2018
Contributor
Author
|
From a windows machine: From a POSIX machine: |
Member
|
For reference, this restores verbose output from |
joyeecheung
approved these changes
Sep 18, 2018
jasnell
approved these changes
Sep 19, 2018
PR-URL: #22935 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
9fe3d1a to
c55ebd8
Compare
Contributor
Author
|
landed in c55ebd8 |
targos
pushed a commit
that referenced
this pull request
Sep 23, 2018
PR-URL: #22935 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Oct 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes