tools: don’t emit illegal utf-8 from icutrim/iculslocs#19756
Merged
srl295 merged 0 commit intonodejs:masterfrom Apr 3, 2018
Merged
tools: don’t emit illegal utf-8 from icutrim/iculslocs#19756srl295 merged 0 commit intonodejs:masterfrom
srl295 merged 0 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
i18n-api
addaleax
approved these changes
Apr 2, 2018
Contributor
Member
Author
|
^ i'll re-open 17077 after this lands. Github doesn't understand the partially part of the commit message. |
Contributor
|
Seems reasonable to me. |
Member
Author
|
node-test-linter:
cause: nodejs/build#1206 (comment) |
bnoordhuis
approved these changes
Apr 3, 2018
jasnell
approved these changes
Apr 3, 2018
targos
pushed a commit
that referenced
this pull request
Apr 3, 2018
- argv[0] was being emitted into a utf-8 stream, but argv[0] may not be legal utf-8 - fix by not emitting argv[0] (was only for a source comment) - partially resolves #17077 PR-URL: #19756 Fixes: #17077 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Aug 17, 2018
- argv[0] was being emitted into a utf-8 stream, but argv[0] may not be legal utf-8 - fix by not emitting argv[0] (was only for a source comment) - partially resolves #17077 PR-URL: #19756 Fixes: #17077 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
not be legal utf-8
Fixes: #17077
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes