test: fix test-abort-backtrace in shared lib build#19213
Closed
yhwang wants to merge 1 commit intonodejs:masterfrom
Closed
test: fix test-abort-backtrace in shared lib build#19213yhwang wants to merge 1 commit intonodejs:masterfrom
yhwang wants to merge 1 commit intonodejs:masterfrom
Conversation
When using shared lib build, the binary path in the stack frames points to shared lib. Change the checking criteria in the test case to match that. Refs: nodejs#18535 Signed-off-by: Yihong Wang <yh.wang@ibm.com>
richardlau
approved these changes
Mar 7, 2018
Member
Author
yhwang
added
the
author ready
cjihrig
approved these changes
Mar 8, 2018
jasnell
approved these changes
Mar 8, 2018
Member
Author
|
|
Member
Author
|
Windows passed but failed on Linux:'test-http-server-keep-alive-timeout-slow-server' . |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 11, 2018
When using shared lib build, the binary path in the stack frames points to shared lib. Change the checking criteria in the test case to match that. Refs: nodejs#18535 Signed-off-by: Yihong Wang <yh.wang@ibm.com> PR-URL: nodejs#19213 Refs: nodejs#18535 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in b325b5b 🎉 |
targos
pushed a commit
that referenced
this pull request
Mar 17, 2018
When using shared lib build, the binary path in the stack frames points to shared lib. Change the checking criteria in the test case to match that. Refs: #18535 Signed-off-by: Yihong Wang <yh.wang@ibm.com> PR-URL: #19213 Refs: #18535 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 20, 2018
When using shared lib build, the binary path in the stack frames points to shared lib. Change the checking criteria in the test case to match that. Refs: #18535 Signed-off-by: Yihong Wang <yh.wang@ibm.com> PR-URL: #19213 Refs: #18535 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
When using shared lib build, the binary path in the stack frames points to shared lib. Change the checking criteria in the test case to match that. Refs: nodejs#18535 Signed-off-by: Yihong Wang <yh.wang@ibm.com> PR-URL: nodejs#19213 Refs: nodejs#18535 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
to jasnell/node
that referenced
this pull request
Aug 17, 2018
When using shared lib build, the binary path in the stack frames points to shared lib. Change the checking criteria in the test case to match that. Refs: nodejs#18535 Signed-off-by: Yihong Wang <yh.wang@ibm.com> PR-URL: nodejs#19213 Refs: nodejs#18535 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 6, 2018
When using shared lib build, the binary path in the stack frames points to shared lib. Change the checking criteria in the test case to match that. Refs: #18535 Signed-off-by: Yihong Wang <yh.wang@ibm.com> Backport-PR-URL: #22380 PR-URL: #19213 Refs: #18535 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using shared lib build, the binary path in the stack frames points
to shared lib. Change the checking criteria in the test case to match
that.
Refs: #18535
Signed-off-by: Yihong Wang yh.wang@ibm.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes