n-api: remove extra reference from test#18542
n-api: remove extra reference from test#18542gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
Conversation
|
https://ci.nodejs.org/job/node-test-commit-arm/13651/nodes=ubuntu1604-arm64_odroid_c2/consoleFull fails in the same way as other builds, such as https://ci.nodejs.org/job/node-test-commit-arm/13649/nodes=ubuntu1604-arm64_odroid_c2/consoleFull and https://ci.nodejs.org/job/node-test-commit-arm/13649/nodes=ubuntu1604-arm64_odroid_c2/consoleFull I don't think the fact that deps/openssl/openssl/crypto/x509v3/v3_purp.c sometimes fails to compile is an error related to this change. In fact, it seems like the file gets corrupted, because there are stray characters in the input in these builds, whereas in builds like https://ci.nodejs.org/job/node-test-commit-arm/13650/nodes=ubuntu1604-arm64_odroid_c2/consoleFull the same file compiles just fine. |
|
Landed in d379db3. |
PR-URL: #18542 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #18542 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #18542 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #18542 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: nodejs#18542 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: nodejs#18542 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: nodejs#18542 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
n-api