doc: value choice for imitating the old behavior of http.Server.keepAliveTimeout#17660
Closed
TysonAndre wants to merge 2 commits intonodejs:masterfrom
TysonAndre:document-keepAliveTimeout-behavior
Closed
doc: value choice for imitating the old behavior of http.Server.keepAliveTimeout#17660TysonAndre wants to merge 2 commits intonodejs:masterfrom TysonAndre:document-keepAliveTimeout-behavior
TysonAndre wants to merge 2 commits intonodejs:masterfrom
TysonAndre:document-keepAliveTimeout-behavior
Conversation
nodejs-github-bot
added
doc
Trott
reviewed
Dec 14, 2017
doc/api/http.md
Outdated
Member
There was a problem hiding this comment.
Please change behaves to behave and nodejs to Node.js.
Member
There was a problem hiding this comment.
Also, while we're in here, it would be good to put backticks around 0 so it's `0`?
Trott
reviewed
Dec 14, 2017
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
Hi, @TysonAndre! Welcome and thanks for the pull request. I have no opinion on whether the actual change should go through or not--it's not clear to me that catering to people looking to emulate old versions is good for the documentation. But if it does go through, there are some grammar/style corrections that will need to happen. I've left a pair of comments. Please take a look. Thanks again!
…liveTimeout Documenting the best way to imitate the old behavior saves time for people migrating from older versions. (E.g. for unexpected ECONNRESET) It isn't immediately obvious if earlier nodejs versions behaved the same way as nodejs 8 does with keepAliveTimeout = 0. From 0aa7ef5, it seems like they behave the same way. Related to issues such as #13391 that show up when migrating to node 8
jasnell
approved these changes
Dec 14, 2017
Trott
approved these changes
Dec 14, 2017
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
Making the change additive like this is 👍 by me. Optional improvement: Might be good to include the exact version in which it changed. So instead of earlier Node.js versions it could be Node.js versions prior to 8.0.0 or whatever the right version number is.
lpinca
approved these changes
Dec 14, 2017
addaleax
approved these changes
Dec 27, 2017
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM if @apapirovski is happy with it
jasnell
approved these changes
Dec 27, 2017
apapirovski
approved these changes
Dec 27, 2017
Contributor
apapirovski
left a comment
apapirovski
left a comment
There was a problem hiding this comment.
LGTM from a technical perspective. Maybe not having the "A value of 0" repeat would be possible but that can be adjusted in a different PR if someone feels passionate enough about it.
Member
jasnell
pushed a commit
that referenced
this pull request
Dec 28, 2017
Documenting the best way to imitate the old behavior saves time for people migrating from older versions. (E.g. for unexpected ECONNRESET) It isn't immediately obvious if earlier nodejs versions behaved the same way as nodejs 8 does with keepAliveTimeout = 0. From 0aa7ef5, it seems like they behave the same way. Related to issues such as #13391 that show up when migrating to node 8 PR-URL: #17660 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Member
|
Landed in 214bbb5 |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 8, 2018
Documenting the best way to imitate the old behavior saves time for people migrating from older versions. (E.g. for unexpected ECONNRESET) It isn't immediately obvious if earlier nodejs versions behaved the same way as nodejs 8 does with keepAliveTimeout = 0. From 0aa7ef5, it seems like they behave the same way. Related to issues such as #13391 that show up when migrating to node 8 PR-URL: #17660 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
Documenting the best way to imitate the old behavior saves time for people migrating from older versions. (E.g. for unexpected ECONNRESET) It isn't immediately obvious if earlier nodejs versions behaved the same way as nodejs 8 does with keepAliveTimeout = 0. From 0aa7ef5, it seems like they behave the same way. Related to issues such as #13391 that show up when migrating to node 8 PR-URL: #17660 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 9, 2018
Documenting the best way to imitate the old behavior saves time for people migrating from older versions. (E.g. for unexpected ECONNRESET) It isn't immediately obvious if earlier nodejs versions behaved the same way as nodejs 8 does with keepAliveTimeout = 0. From 0aa7ef5, it seems like they behave the same way. Related to issues such as #13391 that show up when migrating to node 8 PR-URL: #17660 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Jan 24, 2018
Documenting the best way to imitate the old behavior saves time for people migrating from older versions. (E.g. for unexpected ECONNRESET) It isn't immediately obvious if earlier nodejs versions behaved the same way as nodejs 8 does with keepAliveTimeout = 0. From 0aa7ef5, it seems like they behave the same way. Related to issues such as #13391 that show up when migrating to node 8 PR-URL: #17660 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Documenting the best way to imitate the old behavior saves time for people
migrating from older versions.
(E.g. for unexpected ECONNRESET)
It isn't immediately obvious if earlier nodejs versions behaved the same
way as nodejs 8 does with keepAliveTimeout = 0.
From 0aa7ef5, it seems like they behave
the same way.
Related to issues such as #13391 that show up when migrating to node 8
Affected core subsystem(s)
doc