tools: don't lint-md as part of main lint target#17587
Closed
refack wants to merge 1 commit intonodejs:masterfrom
Closed
tools: don't lint-md as part of main lint target#17587refack wants to merge 1 commit intonodejs:masterfrom
refack wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
build
Contributor
Author
|
#17330 will complement this change, in that is minimizes git noise even when running |
Contributor
Author
|
preliminary CI: https://ci.nodejs.org/job/node-test-pull-request-lite/ |
cjihrig
approved these changes
Dec 11, 2017
Member
|
Hm, I would really like to find a good solution for this. I like the linter a lot. But oh well, I guess it is to run one more command for most PRs now. |
MylesBorins
added
the
fast-track
MylesBorins
approved these changes
Dec 11, 2017
Contributor
MylesBorins
left a comment
MylesBorins
left a comment
There was a problem hiding this comment.
LGTM we should land asap
Contributor
|
@BridgeAR this is a temporary solution while we figure out a better way to maintain dependencies inside of the tree (to avoid landing 2k new files in tree). I'm very much into getting a better solution together and bringing the linter back into the fray |
BridgeAR
approved these changes
Dec 11, 2017
Contributor
|
landed in 51a7d97 |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 11, 2017
PR-URL: #17587 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17587 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17587 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
May 22, 2018
PR-URL: #17587 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 14, 2018
PR-URL: #17587 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
3 tasks
rvagg
pushed a commit
that referenced
this pull request
Aug 16, 2018
PR-URL: #17587 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Followup to #17320.
As per discussion in TSC Meeting from 2017-12-06 skip linting markdown files as part of the
linttarget.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools,build