Skip to content

tools: add lowercase-name-for-primitive eslint rule#17568

Closed
starkwang wants to merge 1 commit intonodejs:masterfrom
starkwang:lowercase-for-primitive
Closed

tools: add lowercase-name-for-primitive eslint rule#17568
starkwang wants to merge 1 commit intonodejs:masterfrom
starkwang:lowercase-for-primitive

Conversation

@starkwang
Copy link
Contributor

@starkwang starkwang commented Dec 9, 2017 •
edited
Loading

The primitive types should use lowercase in error message.

refs: #16383, #16401

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

tools, test

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 9, 2017
targos
targos approved these changes Dec 9, 2017
View reviewed changes
tools/eslint-rules/lowercase-name-for-primitive.js Outdated
Copy link
Member

@targos targos Dec 9, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/captialized/lowercase

@starkwang
tools: add lowercase-name-for-primitive eslint rule
ea94065 
Primitives should use lowercase in error message.

refs: nodejs#16401
@starkwang starkwang force-pushed the lowercase-for-primitive branch from 1d2fbce to ea94065 Compare December 9, 2017 14:43
@apapirovski
Copy link
Contributor

apapirovski commented Dec 12, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/12063/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 12, 2017
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 13, 2017
@starkwang @addaleax
tools: add lowercase-name-for-primitive eslint rule
a2bdcba 
Primitives should use lowercase in error message.

Refs: nodejs#16401
PR-URL: nodejs#17568
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax
Copy link
Member

addaleax commented Dec 13, 2017

Landed in a2bdcba

@addaleax addaleax closed this Dec 13, 2017
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 13, 2017
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
@starkwang @MylesBorins
tools: add lowercase-name-for-primitive eslint rule
3ad8cf1 
Primitives should use lowercase in error message.

Refs: #16401
PR-URL: #17568
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 10, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Jan 22, 2018
@starkwang @MylesBorins
tools: add lowercase-name-for-primitive eslint rule
dc480f8 
Primitives should use lowercase in error message.

Refs: #16401
PR-URL: #17568
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 22, 2018
@starkwang @MylesBorins
tools: add lowercase-name-for-primitive eslint rule
0f002dd 
Primitives should use lowercase in error message.

Refs: #16401
PR-URL: #17568
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2018
Merged
MylesBorins pushed a commit that referenced this pull request Feb 11, 2018
@starkwang @MylesBorins
tools: add lowercase-name-for-primitive eslint rule
de25741 
Primitives should use lowercase in error message.

Refs: #16401
PR-URL: #17568
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 12, 2018
@starkwang @MylesBorins
tools: add lowercase-name-for-primitive eslint rule
f0c1855 
Primitives should use lowercase in error message.

Refs: #16401
PR-URL: #17568
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 13, 2018
@starkwang @MylesBorins
tools: add lowercase-name-for-primitive eslint rule
7821a4c 
Primitives should use lowercase in error message.

Refs: #16401
PR-URL: #17568
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@targos targos targos approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@starkwang @apapirovski @addaleax @jasnell @targos @BridgeAR @MylesBorins @nodejs-github-bot