Skip to content

doc: add ES Modules entry to who-to-cc#17205

Closed
Trott wants to merge 2 commits intonodejs:masterfrom
Trott:extra-extra
Closed

doc: add ES Modules entry to who-to-cc#17205
Trott wants to merge 2 commits intonodejs:masterfrom
Trott:extra-extra

Conversation

@Trott
Copy link
Member

@Trott Trott commented Nov 22, 2017

Add ES Modules entry for who-to-cc. Resisted temptation to change it to
"whom to CC". Did add other minor fixes, though (whitespace and moving
async_hooks, removing unnecessary escaping).

Checklist
Affected core subsystem(s)

doc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Nov 22, 2017
@Trott
doc: add ES Modules entry to who-to-cc
6d627ac 
Add ES Modules entry for who-to-cc. Resisted temptation to change it to
"whom to CC". Did move async_hooks entry, though.
@refack
Copy link
Contributor

refack commented Nov 22, 2017

LGTM, but maybe you should ping the subjects of this changes?
Also 5 people seems like a reason for a team, no?

@Trott
Copy link
Member Author

Trott commented Nov 22, 2017

Also 5 people seems like a reason for a team, no?

Let's see if they all really actually want to be pinged for ES Modules stuff. I can see @jasnell and/or @Fishrock123 deciding that they'll opt out of this one....

@jasnell
Copy link
Member

jasnell commented Nov 22, 2017

Feel free to remove me from the list for es modules

@targos
Copy link
Member

targos commented Nov 22, 2017 •
edited
Loading

You can add me to the list. I also think an @nodejs/esm team would make sense.

@Trott
Copy link
Member Author

Trott commented Nov 25, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11698/

@Trott
Copy link
Member Author

Trott commented Nov 25, 2017

Linter is green. Going to land...

Trott added a commit to Trott/io.js that referenced this pull request Nov 25, 2017
@Trott
doc: add ES Modules entry to who-to-cc
73154c0 
Add ES Modules entry for who-to-cc. Resisted temptation to change it to
"whom to CC". Did move async_hooks entry, though.

PR-URL: nodejs#17205
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
@Trott
Copy link
Member Author

Trott commented Nov 25, 2017

Landed in 73154c0.

@Trott Trott closed this Nov 25, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@Trott @MylesBorins
doc: add ES Modules entry to who-to-cc
ecdffbf 
Add ES Modules entry for who-to-cc. Resisted temptation to change it to
"whom to CC". Did move async_hooks entry, though.

PR-URL: #17205
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@Trott @MylesBorins
doc: add ES Modules entry to who-to-cc
c901cce 
Add ES Modules entry for who-to-cc. Resisted temptation to change it to
"whom to CC". Did move async_hooks entry, though.

PR-URL: #17205
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@Trott @gibfahn
doc: add ES Modules entry to who-to-cc
ae5a870 
Add ES Modules entry for who-to-cc. Resisted temptation to change it to
"whom to CC". Did move async_hooks entry, though.

PR-URL: #17205
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@Trott @gibfahn
doc: add ES Modules entry to who-to-cc
cd3defe 
Add ES Modules entry for who-to-cc. Resisted temptation to change it to
"whom to CC". Did move async_hooks entry, though.

PR-URL: #17205
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@Trott Trott deleted the extra-extra branch January 13, 2022 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

+4 more reviewers

@refack refack refack approved these changes

@danbev danbev danbev approved these changes

@maclover7 maclover7 maclover7 approved these changes

@aqrln aqrln aqrln approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.