Closed
Conversation
joaocgreis
added
doc
nodejs-github-bot
added
build
Member
Author
gireeshpunathil
approved these changes
Nov 14, 2017
joyeecheung
approved these changes
Nov 14, 2017
TimothyGu
approved these changes
Nov 14, 2017
BUILDING.md
Outdated
| the GNU/Linux build process and binaries should work. The community will | ||
| only address issues that reproduce on native GNU/Linux systems, issues that | ||
| only reproduce on WSL should be reported in the | ||
| [WSL issue tracker](https://github.com/Microsoft/WSL/issues). |
Member
There was a problem hiding this comment.
It would be good to mention executing node.exe in WSL is not supported either.
Contributor
There was a problem hiding this comment.
Running the Windows binary (`node.exe`) in WSL is not supported, not recommended,
and will not work without adjustment (such as stdio standard stream redirection).
richardlau
approved these changes
Nov 14, 2017
gibfahn
approved these changes
Nov 14, 2017
jasnell
approved these changes
Nov 14, 2017
digitalinfinity
approved these changes
Nov 14, 2017
cjihrig
approved these changes
Nov 14, 2017
Trott
reviewed
Nov 14, 2017
BUILDING.md
Outdated
|
|
||
| *Note*: The Windows Subsystem for Linux (WSL) is not directly supported, but | ||
| the GNU/Linux build process and binaries should work. The community will | ||
| only address issues that reproduce on native GNU/Linux systems, issues that |
Member
There was a problem hiding this comment.
Nit: systems, issues that -> systems. Issues that
Trott
reviewed
Nov 14, 2017
BUILDING.md
Outdated
| In "Git bash" if you call the node shell alias (`node` without the `.exe` | ||
| extension), `winpty` is used automatically. | ||
|
|
||
| *Note*: The Windows Subsystem for Linux (WSL) is not directly supported, but |
Member
There was a problem hiding this comment.
Nit: Perhaps remove *Note*: and let the paragraph stand on its own?
Member
Author
|
Addressed feedback, PTAL. @TimothyGu @refack Windows binaries should work in WSL, so saying it's not supported is too strong. We don't want to work around bugs in WSL, but if it can provide a valid Windows environment it should work. I've left the "is not recommended", should be clear enough. |
joaocgreis
added a commit
that referenced
this pull request
Nov 17, 2017
Fixes: #13471 PR-URL: #17008 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
Author
|
Landed in d8debd8 |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Fixes: #13471 PR-URL: #17008 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
Fixes: #13471 PR-URL: #17008 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
|
@nodejs/build @nodejs/platform-windows I backported this to v8.x-staging and v6.x-staging, as I think the support statement is true for LTS lines as well. If anyone disagrees LMK. |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 19, 2017
Fixes: #13471 PR-URL: #17008 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Contributor
|
SGTM |
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Fixes: #13471 PR-URL: #17008 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Hitesh Kanwathirtha <hiteshk@microsoft.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following the discussion in #13471, this adds a note to
BUILDING.mdto clarify WSL support.cc @nodejs/platform-windows @nodejs/build
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc, win