doc: fix a typo in n-api documentation#16879
Closed
vipinmenon wants to merge 1 commit intonodejs:masterfrom
Closed
doc: fix a typo in n-api documentation#16879vipinmenon wants to merge 1 commit intonodejs:masterfrom
vipinmenon wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
doc
gireeshpunathil
approved these changes
Nov 8, 2017
Member
gireeshpunathil
left a comment
gireeshpunathil
left a comment
There was a problem hiding this comment.
trivial change, can be fast-tracked
Member
danbev
approved these changes
Nov 8, 2017
Trott
approved these changes
Nov 8, 2017
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 8, 2017
PR-URL: nodejs#16879 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
|
Landed in f2cb78c. |
evanlucas
pushed a commit
that referenced
this pull request
Nov 13, 2017
PR-URL: #16879 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 13, 2017
PR-URL: #16879 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 16, 2018
PR-URL: nodejs#16879 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make -j4 test(UNIX), orvcbuild test(Windows) passesTrivial typo correction, my first PR to this repo, thanks in advance!