deps: upgrade libuv to 1.16.1 by cjihrig · Pull Request #16835 · nodejs/node

cjihrig · 2017-11-06T16:48:34Z

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

deps

bnoordhuis

Rubber-stamp LGTM.

cjihrig · 2017-11-07T18:50:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/11279/

EDIT: Another CI run, but the problem looks persistent: https://ci.nodejs.org/job/node-test-commit/13843/

refack

Rubbar-Stamp

cjihrig · 2017-11-07T22:24:50Z

@nodejs/platform-aix any ideas on the compilation errors?

https://ci.nodejs.org/job/node-test-commit-aix/10098/nodes=aix61-ppc64/console

refack · 2017-11-07T23:07:44Z

That's AIX host has been crazy for a couple of days. I took it off-line (again) and rerun:
https://ci.nodejs.org/job/node-test-commit-aix/10099/nodes=aix61-ppc64/

cjihrig · 2017-11-08T14:08:09Z

No luck @refack. I just started a fresh CI run and encountered the same compilation error. Someone from @nodejs/platform-aix may have to look into this.

mhdawson · 2017-11-08T15:21:42Z

@gireeshpunathil @jBarz can you two jump in to resolve the AIX compilation issue

gireeshpunathil · 2017-11-08T15:50:34Z

apologies, completely missed this in hundreds of github notification mails.

@tagos and I had recently resolved a couple of v8 build breaks in AIX and has upstreamed them, probably that is applicable here. I will get to the bottom of it tomorrow (late night for me now here), if it is not resolved by then.

jBarz · 2017-11-08T16:53:45Z

The issue is a conflict between a macro defined in aix system headers

#define Free(p) free((char *)p);

And the following method in node_internals.h

virtual void Free(void* data, size_t) { free(data); }

Which is derived from the Free method in the v8::Allocator api

virtual void Free(void* data, size_t length) = 0

refack · 2017-11-08T16:55:33Z

#define Free(p) free((char *)p);

Can we add an #undef Free statement in node_internals.h?

jBarz · 2017-11-08T16:56:13Z

I don't see why not. That should fix it!

cjihrig · 2017-11-08T17:00:57Z

Any idea why this is just becoming an issue in this PR? Is it a new #include in libuv?

jBarz · 2017-11-08T17:06:26Z

+#include <net/if.h>

in uv-unix.h

jBarz · 2017-11-08T17:10:13Z

Actually, removing that line fixes the issue as well.
We could ifdef it out for aix.

cjihrig · 2017-11-08T17:39:57Z

@jBarz proposed fix in libuv: libuv/libuv#1622

This commit moves the net/if.h include into src/getaddrinfo.c to prevent AIX compilation errors. With these symbols exposed publicly, Node.js compilation failed on AIX by exposing Free(), which conflicts with another API. Refs: nodejs/node#16835 Refs: libuv#1445 PR-URL: libuv#1622 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

NDIS_IF_MAX_STRING_SIZE does not appear to be available on some Windows systems. This commit defines it using the same logic used by Wireshark. See: https://github.com/boundary/wireshark/blob/07eade8124fd1d5386161591b52e177ee6ea849f/capture_win_ifnames.c#L42-L44 Refs: nodejs/node#16835 Refs: #1445 PR-URL: #1623 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>

cjihrig · 2017-11-10T17:49:28Z

New CI with libuv 1.16.1: https://ci.nodejs.org/job/node-test-commit/13912/

EDIT: Added another CI to verify that the one test failure from the first run wasn't related. https://ci.nodejs.org/job/node-test-commit/13913/

refack

Re-stamp

PR-URL: nodejs#16835 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins · 2017-11-17T15:41:08Z

Is there a reason this was not marked semver-minor? If so please feel free to remove the label

This should land on v8.x for sure, and perhaps v6.x (if we do another minor)

PR-URL: #16835 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This LTS release comes with 109 commits, 17 of which are considered Semver-Minor. This includes 32 which are doc related, 29 which are test related, 8 which are build / tool related and 1 commit which updates a dependency. Notable Changes: * console: - added console.count() and console.clear() (James M Snell) #12678 * crypto: - expose ECDH class (Bryan English) #8188 - added cypto.randomFill() and crypto.randomFillSync() (Evan Lucas) #10209 - warn on invalid authentication tag length (Tobias Nießen) #17566 * deps: - upgrade libuv to 1.16.1 (cjihrig) #16835 * dgram: - added socket.setMulticastInterface() (Will Young) #7855 * http: - add agent.keepSocketAlive and agent.reuseSocket as to allow overridable keep-alive behavior of `Agent` (Fedor Indutny) #13005 * lib: - return this from net.Socket.end() (Sam Roberts) #13481 * module: - add builtinModules api that provides list of all builtin modules in Node (Jon Moss) #16386 * net: - return this from getConnections() (Sam Roberts) #13553 * promises: - more robust stringification for unhandled rejections (Timothy Gu) #13784 * repl: - improve require() autocompletion (Alexey Orlenko) #14409 * src: - add openssl-system-ca-path configure option (Daniel Bevenius) #16790 - add --use-bundled-ca --use-openssl-ca check (Daniel Bevenius) #12087 - add process.ppid (cjihrig) #16839 * tls: - accept `lookup` option for `tls.connect()` (Fedor Indutny) #12839 * tools, build: - a new macOS installer! (JP Wesselink) #15179 * url: - WHATWG URL api support (James M Snell) #7448 * util: - add %i and %f formatting specifiers (Roman Reiss) #10308 PR-URL: #18342

PR-URL: #16835 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This LTS release comes with 109 commits, 17 of which are considered Semver-Minor. This includes 32 which are doc related, 29 which are test related, 8 which are build / tool related and 1 commit which updates a dependency. Notable Changes: * console: - added console.count() and console.clear() (James M Snell) #12678 * crypto: - expose ECDH class (Bryan English) #8188 - added cypto.randomFill() and crypto.randomFillSync() (Evan Lucas) #10209 - warn on invalid authentication tag length (Tobias Nießen) #17566 * deps: - upgrade libuv to 1.16.1 (cjihrig) #16835 * dgram: - added socket.setMulticastInterface() (Will Young) #7855 * http: - add agent.keepSocketAlive and agent.reuseSocket as to allow overridable keep-alive behavior of `Agent` (Fedor Indutny) #13005 * lib: - return this from net.Socket.end() (Sam Roberts) #13481 * module: - add builtinModules api that provides list of all builtin modules in Node (Jon Moss) #16386 * net: - return this from getConnections() (Sam Roberts) #13553 * promises: - more robust stringification for unhandled rejections (Timothy Gu) #13784 * repl: - improve require() autocompletion (Alexey Orlenko) #14409 * src: - add openssl-system-ca-path configure option (Daniel Bevenius) #16790 - add --use-bundled-ca --use-openssl-ca check (Daniel Bevenius) #12087 - add process.ppid (cjihrig) #16839 * tls: - accept `lookup` option for `tls.connect()` (Fedor Indutny) #12839 * tools, build: - a new macOS installer! (JP Wesselink) #15179 * url: - WHATWG URL api support (James M Snell) #7448 * util: - add %i and %f formatting specifiers (Roman Reiss) #10308 PR-URL: #18342

PR-URL: #16835 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

This LTS release comes with 109 commits, 17 of which are considered Semver-Minor. This includes 32 which are doc related, 29 which are test related, 8 which are build / tool related and 1 commit which updates a dependency. Notable Changes: * console: - added console.count() and console.clear() (James M Snell) #12678 * crypto: - expose ECDH class (Bryan English) #8188 - added cypto.randomFill() and crypto.randomFillSync() (Evan Lucas) #10209 - warn on invalid authentication tag length (Tobias Nießen) #17566 * deps: - upgrade libuv to 1.16.1 (cjihrig) #16835 * dgram: - added socket.setMulticastInterface() (Will Young) #7855 * http: - add agent.keepSocketAlive and agent.reuseSocket as to allow overridable keep-alive behavior of `Agent` (Fedor Indutny) #13005 * lib: - return this from net.Socket.end() (Sam Roberts) #13481 * module: - add builtinModules api that provides list of all builtin modules in Node (Jon Moss) #16386 * net: - return this from getConnections() (Sam Roberts) #13553 * promises: - more robust stringification for unhandled rejections (Timothy Gu) #13784 * repl: - improve require() autocompletion (Alexey Orlenko) #14409 * src: - add openssl-system-ca-path configure option (Daniel Bevenius) #16790 - add --use-bundled-ca --use-openssl-ca check (Daniel Bevenius) #12087 - add process.ppid (cjihrig) #16839 * tls: - accept `lookup` option for `tls.connect()` (Fedor Indutny) #12839 * tools, build: - a new macOS installer! (JP Wesselink) #15179 * url: - WHATWG URL api support (James M Snell) #7448 * util: - add %i and %f formatting specifiers (Roman Reiss) #10308 PR-URL: #18342

This LTS release comes with 112 commits, 17 of which are considered Semver-Minor. This includes 32 which are doc related, 30 which are test related, 8 which are build / tool related and 1 commit which updates a dependency. Notable Changes: * console: - added console.count() and console.clear() (James M Snell) #12678 * crypto: - expose ECDH class (Bryan English) #8188 - added cypto.randomFill() and crypto.randomFillSync() (Evan Lucas) #10209 - warn on invalid authentication tag length (Tobias Nießen) #17566 * deps: - upgrade libuv to 1.16.1 (cjihrig) #16835 * dgram: - added socket.setMulticastInterface() (Will Young) #7855 * http: - add agent.keepSocketAlive and agent.reuseSocket as to allow overridable keep-alive behavior of `Agent` (Fedor Indutny) #13005 * lib: - return this from net.Socket.end() (Sam Roberts) #13481 * module: - add builtinModules api that provides list of all builtin modules in Node (Jon Moss) #16386 * net: - return this from getConnections() (Sam Roberts) #13553 * promises: - more robust stringification for unhandled rejections (Timothy Gu) #13784 * repl: - improve require() autocompletion (Alexey Orlenko) #14409 * src: - add openssl-system-ca-path configure option (Daniel Bevenius) #16790 - add --use-bundled-ca --use-openssl-ca check (Daniel Bevenius) #12087 - add process.ppid (cjihrig) #16839 * tls: - accept `lookup` option for `tls.connect()` (Fedor Indutny) #12839 * tools, build: - a new macOS installer! (JP Wesselink) #15179 * url: - WHATWG URL api support (James M Snell) #7448 * util: - add %i and %f formatting specifiers (Roman Reiss) #10308 PR-URL: #18342

This LTS release comes with 112 commits, 17 of which are considered Semver-Minor. This includes 32 which are doc related, 30 which are test related, 8 which are build / tool related and 1 commit which updates a dependency. Notable Changes: * console: - added console.count() and console.clear() (James M Snell) nodejs#12678 * crypto: - expose ECDH class (Bryan English) nodejs#8188 - added cypto.randomFill() and crypto.randomFillSync() (Evan Lucas) nodejs#10209 - warn on invalid authentication tag length (Tobias Nießen) nodejs#17566 * deps: - upgrade libuv to 1.16.1 (cjihrig) nodejs#16835 * dgram: - added socket.setMulticastInterface() (Will Young) nodejs#7855 * http: - add agent.keepSocketAlive and agent.reuseSocket as to allow overridable keep-alive behavior of `Agent` (Fedor Indutny) nodejs#13005 * lib: - return this from net.Socket.end() (Sam Roberts) nodejs#13481 * module: - add builtinModules api that provides list of all builtin modules in Node (Jon Moss) nodejs#16386 * net: - return this from getConnections() (Sam Roberts) nodejs#13553 * promises: - more robust stringification for unhandled rejections (Timothy Gu) nodejs#13784 * repl: - improve require() autocompletion (Alexey Orlenko) nodejs#14409 * src: - add openssl-system-ca-path configure option (Daniel Bevenius) nodejs#16790 - add --use-bundled-ca --use-openssl-ca check (Daniel Bevenius) nodejs#12087 - add process.ppid (cjihrig) nodejs#16839 * tls: - accept `lookup` option for `tls.connect()` (Fedor Indutny) nodejs#12839 * tools, build: - a new macOS installer! (JP Wesselink) nodejs#15179 * url: - WHATWG URL api support (James M Snell) nodejs#7448 * util: - add %i and %f formatting specifiers (Roman Reiss) nodejs#10308 PR-URL: nodejs#18342

nodejs-github-bot added the libuv Issues and PRs related to the libuv dependency or the uv binding. label Nov 6, 2017

cjihrig mentioned this pull request Nov 6, 2017

src: add process.ppid #16839

Merged

4 tasks

bnoordhuis approved these changes Nov 6, 2017

View reviewed changes

gireeshpunathil approved these changes Nov 7, 2017

View reviewed changes

bricss mentioned this pull request Nov 7, 2017

v9.1.0 proposal #16851

Merged

refack approved these changes Nov 7, 2017

View reviewed changes

cjihrig force-pushed the libuv branch from eaaf93b to a670862 Compare November 7, 2017 21:55

jasnell approved these changes Nov 8, 2017

View reviewed changes

cjihrig force-pushed the libuv branch from a670862 to 9f97635 Compare November 8, 2017 13:53

cjihrig mentioned this pull request Nov 8, 2017

unix: move net/if.h include libuv/libuv#1622

Merged

cjihrig force-pushed the libuv branch from 9f97635 to 9240c4b Compare November 10, 2017 17:39

cjihrig changed the title ~~deps: upgrade libuv to 1.16.0~~ deps: upgrade libuv to 1.16.1 Nov 10, 2017

refack approved these changes Nov 10, 2017

View reviewed changes

deps: upgrade libuv to 1.16.1

766cd1f

PR-URL: nodejs#16835 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

MylesBorins added lts-watch-v8.x and removed lts-watch-v4.x labels Nov 17, 2017

MylesBorins mentioned this pull request Jan 24, 2018

v6.13.0 proposal #18342

Merged

gibfahn added land-on-v6.x and removed lts-watch-v6.x labels Feb 19, 2018

Uh oh!

Conversation

cjihrig commented Nov 6, 2017

Checklist

Affected core subsystem(s)

Uh oh!

bnoordhuis left a comment

Choose a reason for hiding this comment

Uh oh!

cjihrig commented Nov 7, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

refack left a comment

Choose a reason for hiding this comment

Uh oh!

cjihrig commented Nov 7, 2017

Uh oh!

refack commented Nov 7, 2017

Uh oh!

cjihrig commented Nov 8, 2017

Uh oh!

mhdawson commented Nov 8, 2017

Uh oh!

gireeshpunathil commented Nov 8, 2017

Uh oh!

jBarz commented Nov 8, 2017

Uh oh!

refack commented Nov 8, 2017

Uh oh!

jBarz commented Nov 8, 2017

Uh oh!

cjihrig commented Nov 8, 2017

Uh oh!

jBarz commented Nov 8, 2017

Uh oh!

jBarz commented Nov 8, 2017

Uh oh!

cjihrig commented Nov 8, 2017

Uh oh!

cjihrig commented Nov 10, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

refack left a comment

Choose a reason for hiding this comment

Uh oh!

MylesBorins commented Nov 17, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

cjihrig commented Nov 7, 2017 •

edited

Loading

cjihrig commented Nov 10, 2017 •

edited

Loading