tools: replace string concatenation with template literals#16806
Closed
lambrojos wants to merge 2 commits intonodejs:masterfrom
Closed
tools: replace string concatenation with template literals#16806lambrojos wants to merge 2 commits intonodejs:masterfrom
lambrojos wants to merge 2 commits intonodejs:masterfrom
Conversation
Replaces a string concatenation in the processList function in doc/json.js.
nodejs-github-bot
added
doc
apapirovski
approved these changes
Nov 6, 2017
Contributor
apapirovski
left a comment
apapirovski
left a comment
There was a problem hiding this comment.
Thanks @lambrojos! Just a small change request below.
tools/doc/json.js
Outdated
| } | ||
| current.textRaw = current.textRaw || ''; | ||
| current.textRaw += `${tok.text} `; | ||
| current.textRaw = `${current.textRaw}${tok.text} `; |
Contributor
There was a problem hiding this comment.
Maybe a slightly better way of doing this would be to make it all one line, like so:
current.textRaw = `${current.textRaw || ''}${tok.text} `;If missing, initialize the textRow property in the same line of the concatenation.
apapirovski
added
the
code-and-learn
gireeshpunathil
approved these changes
Nov 6, 2017
Member
vsemozhetbyt
approved these changes
Nov 6, 2017
Trott
approved these changes
Nov 6, 2017
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 6, 2017
Replace a string concatenation in the processList function in doc/json.js. If missing, initialize the textRow property in the same line of the concatenation. PR-URL: nodejs#16806 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
|
Landed in cab34ba. Thanks for the contribution! 🎉 |
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Nov 6, 2017
Replace a string concatenation in the processList function in doc/json.js. If missing, initialize the textRow property in the same line of the concatenation. PR-URL: nodejs#16806 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
Replace a string concatenation in the processList function in doc/json.js. If missing, initialize the textRow property in the same line of the concatenation. PR-URL: #16806 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
Replace a string concatenation in the processList function in doc/json.js. If missing, initialize the textRow property in the same line of the concatenation. PR-URL: #16806 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
Replace a string concatenation in the processList function in doc/json.js. If missing, initialize the textRow property in the same line of the concatenation. PR-URL: #16806 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
Replace a string concatenation in the processList function in doc/json.js. If missing, initialize the textRow property in the same line of the concatenation. PR-URL: #16806 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces a string concatenation in the processList function
in doc/json.js.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)