Conversation
nodejs-github-bot
added
the
meta
targos
commented
Oct 28, 2017
gireeshpunathil
approved these changes
Oct 28, 2017
lpinca
approved these changes
Oct 28, 2017
lpinca
reviewed
Oct 28, 2017
AUTHORS
Outdated
Member
There was a problem hiding this comment.
Hmm this account can be stolen via the publicly visible disposable email address.
Member
Author
There was a problem hiding this comment.
I if just remove it, it will appear again next time.
I can add it to .mailmap as "Anonymous".
targos
force-pushed
the
update-authors
branch
from
5a4455f to
013a6af
Compare
Member
Author
|
I just rebased and ran the script again, PTAL |
targos
force-pushed
the
update-authors
branch
from
013a6af to
0169871
Compare
Member
Author
|
Updated again. Ping anyone: please review ;) |
gireeshpunathil
approved these changes
Nov 18, 2017
PR-URL: nodejs#16571 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
force-pushed
the
update-authors
branch
from
0169871 to
334a7aa
Compare
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #16571 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Dec 19, 2017
PR-URL: #16571 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
PR-URL: #16571 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #16571 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
For people who have their GitHub handle as name, I picked their real name from the GitHub profile (if present). Should we ping them to ask if that's fine?