aix,test: skip test due to file size limit#16273
Closed
jBarz wants to merge 2 commits intonodejs:masterfrom
Closed
aix,test: skip test due to file size limit#16273jBarz wants to merge 2 commits intonodejs:masterfrom
jBarz wants to merge 2 commits intonodejs:masterfrom
Conversation
The test requires a file size limit that is greater than the string size limit. Some aix machines might not meet this criteria so in which case we should skip the test.
addaleax
approved these changes
Oct 18, 2017
targos
approved these changes
Oct 18, 2017
cjihrig
approved these changes
Oct 18, 2017
Contributor
|
I don't think this should need 48 hours to land. Any one else agree? |
hiroppy
approved these changes
Oct 18, 2017
Member
Contributor
Author
|
My bad, I forgot to multiply by block size (to get the value in bytes). |
gibfahn
approved these changes
Oct 18, 2017
Member
3 tasks
Member
|
OSX failure was unrelated, opened #16321 |
Member
|
Arm failures not related, going to land. |
Member
|
Landed as 31cde1c |
mhdawson
pushed a commit
that referenced
this pull request
Oct 19, 2017
The test requires a file size limit that is greater than the string size limit. Some aix machines might not meet this criteria so in which case we should skip the test. PR-URL: #16273 Fixes: #16319 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: MichaëZasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 23, 2017
The test requires a file size limit that is greater than the string size limit. Some aix machines might not meet this criteria so in which case we should skip the test. PR-URL: #16273 Fixes: #16319 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: MichaëZasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
The test requires a file size limit that is greater than the string size limit. Some aix machines might not meet this criteria so in which case we should skip the test. PR-URL: nodejs/node#16273 Fixes: nodejs/node#16319 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: MichaëZasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2017
The test requires a file size limit that is greater than the string size limit. Some aix machines might not meet this criteria so in which case we should skip the test. PR-URL: #16273 Fixes: #16319 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: MichaëZasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 21, 2017
The test requires a file size limit that is greater than the string size limit. Some aix machines might not meet this criteria so in which case we should skip the test. PR-URL: #16273 Fixes: #16319 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: MichaëZasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 28, 2017
The test requires a file size limit that is greater than the string size limit. Some aix machines might not meet this criteria so in which case we should skip the test. PR-URL: #16273 Fixes: #16319 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: MichaëZasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
The test requires a file size limit that is greater than the string size limit. Some aix machines might not meet this criteria so in which case we should skip the test. PR-URL: nodejs/node#16273 Fixes: nodejs/node#16319 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: MichaëZasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test requires a file size limit that is greater than the string
size limit. Some aix machines might not meet this criteria so in
which case we should skip the test.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)