n-api,test: use module name macro#16146
Closed
gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
Closed
n-api,test: use module name macro#16146gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
Conversation
test_constructor_name.c should use NODE_GYP_MODULE_NAME.
nodejs-github-bot
added
dont-land-on-v4.x
node-api
evanlucas
approved these changes
Oct 11, 2017
mhdawson
reviewed
Oct 11, 2017
Member
mhdawson
left a comment
mhdawson
left a comment
There was a problem hiding this comment.
LGTM, although this probably applies to other tests as well.
Contributor
Author
|
@mhdawson you're right. There are two more in test/addons-napi/test_warning. |
fhinkel
approved these changes
Oct 12, 2017
jasnell
approved these changes
Oct 12, 2017
digitalinfinity
approved these changes
Oct 13, 2017
Contributor
Author
|
Landed in 17b818b. |
gabrielschulhof
pushed a commit
that referenced
this pull request
Oct 13, 2017
test_constructor_name.c should use NODE_GYP_MODULE_NAME. PR-URL: #16146 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 15, 2017
test_constructor_name.c should use NODE_GYP_MODULE_NAME. PR-URL: nodejs/node#16146 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
targos
pushed a commit
that referenced
this pull request
Oct 18, 2017
test_constructor_name.c should use NODE_GYP_MODULE_NAME. PR-URL: #16146 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Apr 16, 2018
test_constructor_name.c should use NODE_GYP_MODULE_NAME. PR-URL: nodejs#16146 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_constructor_name.c should use NODE_GYP_MODULE_NAME.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
n-api,test